aboutsummaryrefslogtreecommitdiffstats
path: root/net/sunrpc
diff options
context:
space:
mode:
authorKinglong Mee <kinglongmee@gmail.com>2014-03-23 23:59:46 -0400
committerJ. Bruce Fields <bfields@redhat.com>2014-03-30 10:47:36 -0400
commitd531c008d7d9713456abe3d265fc577bba2e1cef (patch)
treeeea8a68155e98ba647ba006d24df0efd3ecf3a49 /net/sunrpc
parent83ddfebdd21da669918d7f9854fd592858625f4b (diff)
NFSD/SUNRPC: Check rpc_xprt out of xs_setup_bc_tcp
Besides checking rpc_xprt out of xs_setup_bc_tcp, increase it's reference (it's important). Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net/sunrpc')
-rw-r--r--net/sunrpc/xprt.c12
-rw-r--r--net/sunrpc/xprtsock.c9
2 files changed, 0 insertions, 21 deletions
diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c
index 7d4df99f761f..d173f79947c6 100644
--- a/net/sunrpc/xprt.c
+++ b/net/sunrpc/xprt.c
@@ -1383,15 +1383,3 @@ void xprt_put(struct rpc_xprt *xprt)
1383 if (atomic_dec_and_test(&xprt->count)) 1383 if (atomic_dec_and_test(&xprt->count))
1384 xprt_destroy(xprt); 1384 xprt_destroy(xprt);
1385} 1385}
1386
1387/**
1388 * xprt_get - return a reference to an RPC transport.
1389 * @xprt: pointer to the transport
1390 *
1391 */
1392struct rpc_xprt *xprt_get(struct rpc_xprt *xprt)
1393{
1394 if (atomic_inc_not_zero(&xprt->count))
1395 return xprt;
1396 return NULL;
1397}
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 63ae657f255b..1335239217cd 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -2923,15 +2923,6 @@ static struct rpc_xprt *xs_setup_bc_tcp(struct xprt_create *args)
2923 struct svc_sock *bc_sock; 2923 struct svc_sock *bc_sock;
2924 struct rpc_xprt *ret; 2924 struct rpc_xprt *ret;
2925 2925
2926 if (args->bc_xprt->xpt_bc_xprt) {
2927 /*
2928 * This server connection already has a backchannel
2929 * transport; we can't create a new one, as we wouldn't
2930 * be able to match replies based on xid any more. So,
2931 * reuse the already-existing one:
2932 */
2933 return args->bc_xprt->xpt_bc_xprt;
2934 }
2935 xprt = xs_setup_xprt(args, xprt_tcp_slot_table_entries, 2926 xprt = xs_setup_xprt(args, xprt_tcp_slot_table_entries,
2936 xprt_tcp_slot_table_entries); 2927 xprt_tcp_slot_table_entries);
2937 if (IS_ERR(xprt)) 2928 if (IS_ERR(xprt))