aboutsummaryrefslogtreecommitdiffstats
path: root/net/sunrpc/svcsock.c
diff options
context:
space:
mode:
authorEric Dumazet <dada1@cosmosbay.com>2007-04-19 19:16:32 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2007-04-26 01:23:34 -0400
commitb7aa0bf70c4afb9e38be25f5c0922498d0f8684c (patch)
tree4bc9d61031f4eb40d73887d6bde09e7d6bf2b259 /net/sunrpc/svcsock.c
parent3927f2e8f9afa3424bb51ca81f7abac01ffd0005 (diff)
[NET]: convert network timestamps to ktime_t
We currently use a special structure (struct skb_timeval) and plain 'struct timeval' to store packet timestamps in sk_buffs and struct sock. This has some drawbacks : - Fixed resolution of micro second. - Waste of space on 64bit platforms where sizeof(struct timeval)=16 I suggest using ktime_t that is a nice abstraction of high resolution time services, currently capable of nanosecond resolution. As sizeof(ktime_t) is 8 bytes, using ktime_t in 'struct sock' permits a 8 byte shrink of this structure on 64bit architectures. Some other structures also benefit from this size reduction (struct ipq in ipv4/ip_fragment.c, struct frag_queue in ipv6/reassembly.c, ...) Once this ktime infrastructure adopted, we can more easily provide nanosecond resolution on top of it. (ioctl SIOCGSTAMPNS and/or SO_TIMESTAMPNS/SCM_TIMESTAMPNS) Note : this patch includes a bug correction in compat_sock_get_timestamp() where a "err = 0;" was missing (so this syscall returned -ENOENT instead of 0) Signed-off-by: Eric Dumazet <dada1@cosmosbay.com> CC: Stephen Hemminger <shemminger@linux-foundation.org> CC: John find <linux.kernel@free.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sunrpc/svcsock.c')
-rw-r--r--net/sunrpc/svcsock.c10
1 files changed, 3 insertions, 7 deletions
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index 2772fee93881..22f61aee4824 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -798,16 +798,12 @@ svc_udp_recvfrom(struct svc_rqst *rqstp)
798 dprintk("svc: recvfrom returned error %d\n", -err); 798 dprintk("svc: recvfrom returned error %d\n", -err);
799 } 799 }
800 rqstp->rq_addrlen = sizeof(rqstp->rq_addr); 800 rqstp->rq_addrlen = sizeof(rqstp->rq_addr);
801 if (skb->tstamp.off_sec == 0) { 801 if (skb->tstamp.tv64 == 0) {
802 struct timeval tv; 802 skb->tstamp = ktime_get_real();
803
804 tv.tv_sec = xtime.tv_sec;
805 tv.tv_usec = xtime.tv_nsec / NSEC_PER_USEC;
806 skb_set_timestamp(skb, &tv);
807 /* Don't enable netstamp, sunrpc doesn't 803 /* Don't enable netstamp, sunrpc doesn't
808 need that much accuracy */ 804 need that much accuracy */
809 } 805 }
810 skb_get_timestamp(skb, &svsk->sk_sk->sk_stamp); 806 svsk->sk_sk->sk_stamp = skb->tstamp;
811 set_bit(SK_DATA, &svsk->sk_flags); /* there may be more data... */ 807 set_bit(SK_DATA, &svsk->sk_flags); /* there may be more data... */
812 808
813 /* 809 /*