diff options
author | Stanislav Kinsbursky <skinsbursky@parallels.com> | 2012-07-20 07:57:48 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2012-07-30 20:39:05 -0400 |
commit | caea33da898e4e14f0ba58173e3b7689981d2c0b (patch) | |
tree | 70eba39a96cfb8cd6c9c90ceac9eeac6e9f3cfe4 /net/sunrpc/rpcb_clnt.c | |
parent | 89d77c8fa8e6d1cb7e2cce95b428be30ddcc6f23 (diff) |
SUNRPC: return negative value in case rpcbind client creation error
Without this patch kernel will panic on LockD start, because lockd_up() checks
lockd_up_net() result for negative value.
From my pow it's better to return negative value from rpcbind routines instead
of replacing all such checks like in lockd_up().
Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@vger.kernel.org [>= 3.0]
Diffstat (limited to 'net/sunrpc/rpcb_clnt.c')
-rw-r--r-- | net/sunrpc/rpcb_clnt.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c index 92509ffe15fc..a70acae496e4 100644 --- a/net/sunrpc/rpcb_clnt.c +++ b/net/sunrpc/rpcb_clnt.c | |||
@@ -251,7 +251,7 @@ static int rpcb_create_local_unix(struct net *net) | |||
251 | if (IS_ERR(clnt)) { | 251 | if (IS_ERR(clnt)) { |
252 | dprintk("RPC: failed to create AF_LOCAL rpcbind " | 252 | dprintk("RPC: failed to create AF_LOCAL rpcbind " |
253 | "client (errno %ld).\n", PTR_ERR(clnt)); | 253 | "client (errno %ld).\n", PTR_ERR(clnt)); |
254 | result = -PTR_ERR(clnt); | 254 | result = PTR_ERR(clnt); |
255 | goto out; | 255 | goto out; |
256 | } | 256 | } |
257 | 257 | ||
@@ -298,7 +298,7 @@ static int rpcb_create_local_net(struct net *net) | |||
298 | if (IS_ERR(clnt)) { | 298 | if (IS_ERR(clnt)) { |
299 | dprintk("RPC: failed to create local rpcbind " | 299 | dprintk("RPC: failed to create local rpcbind " |
300 | "client (errno %ld).\n", PTR_ERR(clnt)); | 300 | "client (errno %ld).\n", PTR_ERR(clnt)); |
301 | result = -PTR_ERR(clnt); | 301 | result = PTR_ERR(clnt); |
302 | goto out; | 302 | goto out; |
303 | } | 303 | } |
304 | 304 | ||