sunrpc: replace sunrpc_net->gssd_running flag with a more reliable check

Now that we have a more reliable method to tell if gssd is running, we
can replace the sn->gssd_running flag with a function that will query to
see if it's up and running.

There's also no need to attempt an upcall that we know will fail, so
just return -EACCES if gssd isn't running. Finally, fix the warn_gss()
message not to claim that that the upcall timed out since we don't
necesarily perform one now when gssd isn't running, and remove the
extraneous newline from the message.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

1 files changed, 7 insertions, 10 deletions

diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
index 42fdfc634e56..0a2aee060f9f 100644
--- a/net/sunrpc/auth_gss/auth_gss.c
+++ b/net/sunrpc/auth_gss/auth_gss.c
@@ -536,8 +536,7 @@ static void warn_gssd(void)
         unsigned long now = jiffies;
 
         if (time_after(now, ratelimit)) {
-                printk(KERN_WARNING "RPC: AUTH_GSS upcall timed out.\n"
-                                "Please check user daemon is running.\n");
+                pr_warn("RPC: AUTH_GSS upcall failed. Please check user daemon is running.\n");
                 ratelimit = now + 15*HZ;
         }
 }
@@ -600,7 +599,6 @@ gss_create_upcall(struct gss_auth *gss_auth, struct gss_cred *gss_cred)
         struct rpc_pipe *pipe;
         struct rpc_cred *cred = &gss_cred->gc_base;
         struct gss_upcall_msg *gss_msg;
-        unsigned long timeout;
         DEFINE_WAIT(wait);
         int err;
 
@@ -608,17 +606,16 @@ gss_create_upcall(struct gss_auth *gss_auth, struct gss_cred *gss_cred)
                 __func__, from_kuid(&init_user_ns, cred->cr_uid));
 retry:
         err = 0;
-        /* Default timeout is 15s unless we know that gssd is not running */
-        timeout = 15 * HZ;
-        if (!sn->gssd_running)
-                timeout = HZ >> 2;
+        /* if gssd is down, just skip upcalling altogether */
+        if (!gssd_running(net)) {
+                warn_gssd();
+                return -EACCES;
+        }
         gss_msg = gss_setup_upcall(gss_auth, cred);
         if (PTR_ERR(gss_msg) == -EAGAIN) {
                 err = wait_event_interruptible_timeout(pipe_version_waitqueue,
-                                sn->pipe_version >= 0, timeout);
+                                sn->pipe_version >= 0, 15 * HZ);
                 if (sn->pipe_version < 0) {
-                        if (err == 0)
-                                sn->gssd_running = 0;
                         warn_gssd();
                         err = -EACCES;
                 }