aboutsummaryrefslogtreecommitdiffstats
path: root/net/sctp
diff options
context:
space:
mode:
authorWei Yongjun <yjwei@cn.fujitsu.com>2008-05-09 18:11:53 -0400
committerDavid S. Miller <davem@davemloft.net>2008-05-12 06:11:48 -0400
commitc4492586a618d18e8a5343a04bad0ec606064846 (patch)
treecf9f5a38e3e9330edf61699f5c4cb8ae8876b879 /net/sctp
parent6e40a915de82e00d18f75941e531b40c4e0d94c4 (diff)
sctp: Add address type check while process paramaters of ASCONF chunk
If socket is create by AF_INET type, add IPv6 address to asoc will cause kernel panic while packet is transmitted on that transport. This patch add address type check before process paramaters of ASCONF chunk. If peer is not support this address type, return with error invald parameter. Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
-rw-r--r--net/sctp/sm_make_chunk.c13
1 files changed, 13 insertions, 0 deletions
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index 69a464f1d2b9..6eeee535e94e 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -2827,6 +2827,19 @@ static __be16 sctp_process_asconf_param(struct sctp_association *asoc,
2827 union sctp_addr addr; 2827 union sctp_addr addr;
2828 union sctp_addr_param *addr_param; 2828 union sctp_addr_param *addr_param;
2829 2829
2830 switch (addr_param->v4.param_hdr.type) {
2831 case SCTP_PARAM_IPV6_ADDRESS:
2832 if (!asoc->peer.ipv6_address)
2833 return SCTP_ERROR_INV_PARAM;
2834 break;
2835 case SCTP_PARAM_IPV4_ADDRESS:
2836 if (!asoc->peer.ipv4_address)
2837 return SCTP_ERROR_INV_PARAM;
2838 break;
2839 default:
2840 return SCTP_ERROR_INV_PARAM;
2841 }
2842
2830 addr_param = (union sctp_addr_param *) 2843 addr_param = (union sctp_addr_param *)
2831 ((void *)asconf_param + sizeof(sctp_addip_param_t)); 2844 ((void *)asconf_param + sizeof(sctp_addip_param_t));
2832 2845