diff options
author | Patrick McHardy <kaber@trash.net> | 2007-06-05 19:06:59 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-06-07 16:41:05 -0400 |
commit | b00b4bf94edb42852d55619af453588b2de2dc5e (patch) | |
tree | 01f79f50daf04a1f73a5d93365307711907b3169 /net/sched/sch_atm.c | |
parent | 7c355f532dd43036622e1880c114773463bafd23 (diff) |
[NET_SCHED]: Fix filter double free
cbq and atm destroy their filters twice when destroying inner classes
during qdisc destruction.
Reported-and-tested-by: Strobl Anton <a.strobl@aws-it.at>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_atm.c')
-rw-r--r-- | net/sched/sch_atm.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c index be7d299acd73..d1c383fca82c 100644 --- a/net/sched/sch_atm.c +++ b/net/sched/sch_atm.c | |||
@@ -599,6 +599,7 @@ static void atm_tc_destroy(struct Qdisc *sch) | |||
599 | /* races ? */ | 599 | /* races ? */ |
600 | while ((flow = p->flows)) { | 600 | while ((flow = p->flows)) { |
601 | tcf_destroy_chain(flow->filter_list); | 601 | tcf_destroy_chain(flow->filter_list); |
602 | flow->filter_list = NULL; | ||
602 | if (flow->ref > 1) | 603 | if (flow->ref > 1) |
603 | printk(KERN_ERR "atm_destroy: %p->ref = %d\n",flow, | 604 | printk(KERN_ERR "atm_destroy: %p->ref = %d\n",flow, |
604 | flow->ref); | 605 | flow->ref); |