aboutsummaryrefslogtreecommitdiffstats
path: root/net/sched/act_pedit.c
diff options
context:
space:
mode:
authorPatrick McHardy <kaber@trash.net>2008-01-23 23:36:30 -0500
committerDavid S. Miller <davem@davemloft.net>2008-01-28 18:11:23 -0500
commit53b2bf3f8a652c9c8e86831f94ae2c5767ea54d7 (patch)
treeeba61efed08a932766a32b0b6a60e766f8b44bcb /net/sched/act_pedit.c
parent6fa8c0144b770dac941cf2c15053b6e24f046c8a (diff)
[NET_SCHED]: Use nla_policy for attribute validation in actions
Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_pedit.c')
-rw-r--r--net/sched/act_pedit.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
index 1b9ca45a78e5..3cc4cb9e500e 100644
--- a/net/sched/act_pedit.c
+++ b/net/sched/act_pedit.c
@@ -33,6 +33,10 @@ static struct tcf_hashinfo pedit_hash_info = {
33 .lock = &pedit_lock, 33 .lock = &pedit_lock,
34}; 34};
35 35
36static const struct nla_policy pedit_policy[TCA_PEDIT_MAX + 1] = {
37 [TCA_PEDIT_PARMS] = { .len = sizeof(struct tcf_pedit) },
38};
39
36static int tcf_pedit_init(struct nlattr *nla, struct nlattr *est, 40static int tcf_pedit_init(struct nlattr *nla, struct nlattr *est,
37 struct tc_action *a, int ovr, int bind) 41 struct tc_action *a, int ovr, int bind)
38{ 42{
@@ -47,12 +51,11 @@ static int tcf_pedit_init(struct nlattr *nla, struct nlattr *est,
47 if (nla == NULL) 51 if (nla == NULL)
48 return -EINVAL; 52 return -EINVAL;
49 53
50 err = nla_parse_nested(tb, TCA_PEDIT_MAX, nla, NULL); 54 err = nla_parse_nested(tb, TCA_PEDIT_MAX, nla, pedit_policy);
51 if (err < 0) 55 if (err < 0)
52 return err; 56 return err;
53 57
54 if (tb[TCA_PEDIT_PARMS] == NULL || 58 if (tb[TCA_PEDIT_PARMS] == NULL)
55 nla_len(tb[TCA_PEDIT_PARMS]) < sizeof(*parm))
56 return -EINVAL; 59 return -EINVAL;
57 parm = nla_data(tb[TCA_PEDIT_PARMS]); 60 parm = nla_data(tb[TCA_PEDIT_PARMS]);
58 ksize = parm->nkeys * sizeof(struct tc_pedit_key); 61 ksize = parm->nkeys * sizeof(struct tc_pedit_key);