diff options
author | Peter Zijlstra <peterz@infradead.org> | 2014-03-17 13:06:10 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2014-04-18 08:20:48 -0400 |
commit | 4e857c58efeb99393cba5a5d0d8ec7117183137c (patch) | |
tree | 3f6fd464e4fddb2fe90374c075c9d06603cf8bbc /net/rds | |
parent | 1b15611e1c30b37abe393d411c316cd659920bf5 (diff) |
arch: Mass conversion of smp_mb__*()
Mostly scripted conversion of the smp_mb__* barriers.
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/n/tip-55dhyhocezdw1dg7u19hmh1u@git.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-arch@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'net/rds')
-rw-r--r-- | net/rds/ib_recv.c | 4 | ||||
-rw-r--r-- | net/rds/iw_recv.c | 4 | ||||
-rw-r--r-- | net/rds/send.c | 6 | ||||
-rw-r--r-- | net/rds/tcp_send.c | 2 |
4 files changed, 8 insertions, 8 deletions
diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c index b7ebe23cdedf..d67de453c35a 100644 --- a/net/rds/ib_recv.c +++ b/net/rds/ib_recv.c | |||
@@ -598,7 +598,7 @@ static void rds_ib_set_ack(struct rds_ib_connection *ic, u64 seq, | |||
598 | { | 598 | { |
599 | atomic64_set(&ic->i_ack_next, seq); | 599 | atomic64_set(&ic->i_ack_next, seq); |
600 | if (ack_required) { | 600 | if (ack_required) { |
601 | smp_mb__before_clear_bit(); | 601 | smp_mb__before_atomic(); |
602 | set_bit(IB_ACK_REQUESTED, &ic->i_ack_flags); | 602 | set_bit(IB_ACK_REQUESTED, &ic->i_ack_flags); |
603 | } | 603 | } |
604 | } | 604 | } |
@@ -606,7 +606,7 @@ static void rds_ib_set_ack(struct rds_ib_connection *ic, u64 seq, | |||
606 | static u64 rds_ib_get_ack(struct rds_ib_connection *ic) | 606 | static u64 rds_ib_get_ack(struct rds_ib_connection *ic) |
607 | { | 607 | { |
608 | clear_bit(IB_ACK_REQUESTED, &ic->i_ack_flags); | 608 | clear_bit(IB_ACK_REQUESTED, &ic->i_ack_flags); |
609 | smp_mb__after_clear_bit(); | 609 | smp_mb__after_atomic(); |
610 | 610 | ||
611 | return atomic64_read(&ic->i_ack_next); | 611 | return atomic64_read(&ic->i_ack_next); |
612 | } | 612 | } |
diff --git a/net/rds/iw_recv.c b/net/rds/iw_recv.c index 45033358358e..aa8bf6786008 100644 --- a/net/rds/iw_recv.c +++ b/net/rds/iw_recv.c | |||
@@ -429,7 +429,7 @@ static void rds_iw_set_ack(struct rds_iw_connection *ic, u64 seq, | |||
429 | { | 429 | { |
430 | atomic64_set(&ic->i_ack_next, seq); | 430 | atomic64_set(&ic->i_ack_next, seq); |
431 | if (ack_required) { | 431 | if (ack_required) { |
432 | smp_mb__before_clear_bit(); | 432 | smp_mb__before_atomic(); |
433 | set_bit(IB_ACK_REQUESTED, &ic->i_ack_flags); | 433 | set_bit(IB_ACK_REQUESTED, &ic->i_ack_flags); |
434 | } | 434 | } |
435 | } | 435 | } |
@@ -437,7 +437,7 @@ static void rds_iw_set_ack(struct rds_iw_connection *ic, u64 seq, | |||
437 | static u64 rds_iw_get_ack(struct rds_iw_connection *ic) | 437 | static u64 rds_iw_get_ack(struct rds_iw_connection *ic) |
438 | { | 438 | { |
439 | clear_bit(IB_ACK_REQUESTED, &ic->i_ack_flags); | 439 | clear_bit(IB_ACK_REQUESTED, &ic->i_ack_flags); |
440 | smp_mb__after_clear_bit(); | 440 | smp_mb__after_atomic(); |
441 | 441 | ||
442 | return atomic64_read(&ic->i_ack_next); | 442 | return atomic64_read(&ic->i_ack_next); |
443 | } | 443 | } |
diff --git a/net/rds/send.c b/net/rds/send.c index a82fb660ec00..23718160d71e 100644 --- a/net/rds/send.c +++ b/net/rds/send.c | |||
@@ -107,7 +107,7 @@ static int acquire_in_xmit(struct rds_connection *conn) | |||
107 | static void release_in_xmit(struct rds_connection *conn) | 107 | static void release_in_xmit(struct rds_connection *conn) |
108 | { | 108 | { |
109 | clear_bit(RDS_IN_XMIT, &conn->c_flags); | 109 | clear_bit(RDS_IN_XMIT, &conn->c_flags); |
110 | smp_mb__after_clear_bit(); | 110 | smp_mb__after_atomic(); |
111 | /* | 111 | /* |
112 | * We don't use wait_on_bit()/wake_up_bit() because our waking is in a | 112 | * We don't use wait_on_bit()/wake_up_bit() because our waking is in a |
113 | * hot path and finding waiters is very rare. We don't want to walk | 113 | * hot path and finding waiters is very rare. We don't want to walk |
@@ -661,7 +661,7 @@ void rds_send_drop_acked(struct rds_connection *conn, u64 ack, | |||
661 | 661 | ||
662 | /* order flag updates with spin locks */ | 662 | /* order flag updates with spin locks */ |
663 | if (!list_empty(&list)) | 663 | if (!list_empty(&list)) |
664 | smp_mb__after_clear_bit(); | 664 | smp_mb__after_atomic(); |
665 | 665 | ||
666 | spin_unlock_irqrestore(&conn->c_lock, flags); | 666 | spin_unlock_irqrestore(&conn->c_lock, flags); |
667 | 667 | ||
@@ -691,7 +691,7 @@ void rds_send_drop_to(struct rds_sock *rs, struct sockaddr_in *dest) | |||
691 | } | 691 | } |
692 | 692 | ||
693 | /* order flag updates with the rs lock */ | 693 | /* order flag updates with the rs lock */ |
694 | smp_mb__after_clear_bit(); | 694 | smp_mb__after_atomic(); |
695 | 695 | ||
696 | spin_unlock_irqrestore(&rs->rs_lock, flags); | 696 | spin_unlock_irqrestore(&rs->rs_lock, flags); |
697 | 697 | ||
diff --git a/net/rds/tcp_send.c b/net/rds/tcp_send.c index 81cf5a4c5e40..53b17ca0dff5 100644 --- a/net/rds/tcp_send.c +++ b/net/rds/tcp_send.c | |||
@@ -93,7 +93,7 @@ int rds_tcp_xmit(struct rds_connection *conn, struct rds_message *rm, | |||
93 | rm->m_ack_seq = tc->t_last_sent_nxt + | 93 | rm->m_ack_seq = tc->t_last_sent_nxt + |
94 | sizeof(struct rds_header) + | 94 | sizeof(struct rds_header) + |
95 | be32_to_cpu(rm->m_inc.i_hdr.h_len) - 1; | 95 | be32_to_cpu(rm->m_inc.i_hdr.h_len) - 1; |
96 | smp_mb__before_clear_bit(); | 96 | smp_mb__before_atomic(); |
97 | set_bit(RDS_MSG_HAS_ACK_SEQ, &rm->m_flags); | 97 | set_bit(RDS_MSG_HAS_ACK_SEQ, &rm->m_flags); |
98 | tc->t_last_expected_una = rm->m_ack_seq + 1; | 98 | tc->t_last_expected_una = rm->m_ack_seq + 1; |
99 | 99 | ||