diff options
| author | Stephen Hemminger <stephen@networkplumber.org> | 2013-12-17 14:22:48 -0500 |
|---|---|---|
| committer | Jesse Gross <jesse@nicira.com> | 2014-01-06 18:54:39 -0500 |
| commit | 443cd88c8a31379e95326428bbbd40af25c1d440 (patch) | |
| tree | a70bdb18d4518d40896f2ae0ecda9bbcf0626b57 /net/openvswitch | |
| parent | 09c5e6054e206ecf13945f50711856a5cb2d5de1 (diff) | |
ovs: make functions local
Several functions and datastructures could be local
Found with 'make namespacecheck'
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Jesse Gross <jesse@nicira.com>
Diffstat (limited to 'net/openvswitch')
| -rw-r--r-- | net/openvswitch/datapath.c | 4 | ||||
| -rw-r--r-- | net/openvswitch/datapath.h | 2 | ||||
| -rw-r--r-- | net/openvswitch/vport.c | 6 | ||||
| -rw-r--r-- | net/openvswitch/vport.h | 1 |
4 files changed, 7 insertions, 6 deletions
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 61ae3b86a995..df4692826ead 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c | |||
| @@ -132,7 +132,7 @@ static struct datapath *get_dp(struct net *net, int dp_ifindex) | |||
| 132 | } | 132 | } |
| 133 | 133 | ||
| 134 | /* Must be called with rcu_read_lock or ovs_mutex. */ | 134 | /* Must be called with rcu_read_lock or ovs_mutex. */ |
| 135 | const char *ovs_dp_name(const struct datapath *dp) | 135 | static const char *ovs_dp_name(const struct datapath *dp) |
| 136 | { | 136 | { |
| 137 | struct vport *vport = ovs_vport_ovsl_rcu(dp, OVSP_LOCAL); | 137 | struct vport *vport = ovs_vport_ovsl_rcu(dp, OVSP_LOCAL); |
| 138 | return vport->ops->get_name(vport); | 138 | return vport->ops->get_name(vport); |
| @@ -1466,7 +1466,7 @@ struct genl_family dp_vport_genl_family = { | |||
| 1466 | .parallel_ops = true, | 1466 | .parallel_ops = true, |
| 1467 | }; | 1467 | }; |
| 1468 | 1468 | ||
| 1469 | struct genl_multicast_group ovs_dp_vport_multicast_group = { | 1469 | static struct genl_multicast_group ovs_dp_vport_multicast_group = { |
| 1470 | .name = OVS_VPORT_MCGROUP | 1470 | .name = OVS_VPORT_MCGROUP |
| 1471 | }; | 1471 | }; |
| 1472 | 1472 | ||
diff --git a/net/openvswitch/datapath.h b/net/openvswitch/datapath.h index 62619a4ee649..6be9fbb5e9cb 100644 --- a/net/openvswitch/datapath.h +++ b/net/openvswitch/datapath.h | |||
| @@ -182,14 +182,12 @@ static inline struct vport *ovs_vport_ovsl(const struct datapath *dp, int port_n | |||
| 182 | 182 | ||
| 183 | extern struct notifier_block ovs_dp_device_notifier; | 183 | extern struct notifier_block ovs_dp_device_notifier; |
| 184 | extern struct genl_family dp_vport_genl_family; | 184 | extern struct genl_family dp_vport_genl_family; |
| 185 | extern struct genl_multicast_group ovs_dp_vport_multicast_group; | ||
| 186 | 185 | ||
| 187 | void ovs_dp_process_received_packet(struct vport *, struct sk_buff *); | 186 | void ovs_dp_process_received_packet(struct vport *, struct sk_buff *); |
| 188 | void ovs_dp_detach_port(struct vport *); | 187 | void ovs_dp_detach_port(struct vport *); |
| 189 | int ovs_dp_upcall(struct datapath *, struct sk_buff *, | 188 | int ovs_dp_upcall(struct datapath *, struct sk_buff *, |
| 190 | const struct dp_upcall_info *); | 189 | const struct dp_upcall_info *); |
| 191 | 190 | ||
| 192 | const char *ovs_dp_name(const struct datapath *dp); | ||
| 193 | struct sk_buff *ovs_vport_cmd_build_info(struct vport *, u32 pid, u32 seq, | 191 | struct sk_buff *ovs_vport_cmd_build_info(struct vport *, u32 pid, u32 seq, |
| 194 | u8 cmd); | 192 | u8 cmd); |
| 195 | 193 | ||
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index d830a95f03a4..f28ff7e44144 100644 --- a/net/openvswitch/vport.c +++ b/net/openvswitch/vport.c | |||
| @@ -33,6 +33,9 @@ | |||
| 33 | #include "vport.h" | 33 | #include "vport.h" |
| 34 | #include "vport-internal_dev.h" | 34 | #include "vport-internal_dev.h" |
| 35 | 35 | ||
| 36 | static void ovs_vport_record_error(struct vport *, | ||
| 37 | enum vport_err_type err_type); | ||
| 38 | |||
| 36 | /* List of statically compiled vport implementations. Don't forget to also | 39 | /* List of statically compiled vport implementations. Don't forget to also |
| 37 | * add yours to the list at the bottom of vport.h. */ | 40 | * add yours to the list at the bottom of vport.h. */ |
| 38 | static const struct vport_ops *vport_ops_list[] = { | 41 | static const struct vport_ops *vport_ops_list[] = { |
| @@ -396,7 +399,8 @@ int ovs_vport_send(struct vport *vport, struct sk_buff *skb) | |||
| 396 | * If using the vport generic stats layer indicate that an error of the given | 399 | * If using the vport generic stats layer indicate that an error of the given |
| 397 | * type has occurred. | 400 | * type has occurred. |
| 398 | */ | 401 | */ |
| 399 | void ovs_vport_record_error(struct vport *vport, enum vport_err_type err_type) | 402 | static void ovs_vport_record_error(struct vport *vport, |
| 403 | enum vport_err_type err_type) | ||
| 400 | { | 404 | { |
| 401 | spin_lock(&vport->stats_lock); | 405 | spin_lock(&vport->stats_lock); |
| 402 | 406 | ||
diff --git a/net/openvswitch/vport.h b/net/openvswitch/vport.h index 1a9fbcec6e1b..92137ddc6100 100644 --- a/net/openvswitch/vport.h +++ b/net/openvswitch/vport.h | |||
| @@ -192,7 +192,6 @@ static inline struct vport *vport_from_priv(const void *priv) | |||
| 192 | 192 | ||
| 193 | void ovs_vport_receive(struct vport *, struct sk_buff *, | 193 | void ovs_vport_receive(struct vport *, struct sk_buff *, |
| 194 | struct ovs_key_ipv4_tunnel *); | 194 | struct ovs_key_ipv4_tunnel *); |
| 195 | void ovs_vport_record_error(struct vport *, enum vport_err_type err_type); | ||
| 196 | 195 | ||
| 197 | /* List of statically compiled vport implementations. Don't forget to also | 196 | /* List of statically compiled vport implementations. Don't forget to also |
| 198 | * add yours to the list at the top of vport.c. */ | 197 | * add yours to the list at the top of vport.c. */ |
