diff options
author | Jarno Rajahalme <jrajahalme@nicira.com> | 2014-03-27 15:35:23 -0400 |
---|---|---|
committer | Jesse Gross <jesse@nicira.com> | 2014-05-16 16:40:29 -0400 |
commit | 23dabf88abb48a866fdb19ee08ebcf1ddd9b1840 (patch) | |
tree | cc835b9d88c36d7b3b0c296fb2617f9971c5bd7e /net/openvswitch/datapath.c | |
parent | 8c63ff09bddf944ab0033fea97aacfadfffa76de (diff) |
openvswitch: Remove 5-tuple optimization.
The 5-tuple optimization becomes unnecessary with a later per-NUMA
node stats patch. Remove it first to make the changes easier to
grasp.
Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
Diffstat (limited to 'net/openvswitch/datapath.c')
-rw-r--r-- | net/openvswitch/datapath.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index a3276e3c4feb..8867d7e2d65b 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c | |||
@@ -524,7 +524,7 @@ static int ovs_packet_cmd_execute(struct sk_buff *skb, struct genl_info *info) | |||
524 | packet->protocol = htons(ETH_P_802_2); | 524 | packet->protocol = htons(ETH_P_802_2); |
525 | 525 | ||
526 | /* Build an sw_flow for sending this packet. */ | 526 | /* Build an sw_flow for sending this packet. */ |
527 | flow = ovs_flow_alloc(false); | 527 | flow = ovs_flow_alloc(); |
528 | err = PTR_ERR(flow); | 528 | err = PTR_ERR(flow); |
529 | if (IS_ERR(flow)) | 529 | if (IS_ERR(flow)) |
530 | goto err_kfree_skb; | 530 | goto err_kfree_skb; |
@@ -782,7 +782,6 @@ static int ovs_flow_cmd_new_or_set(struct sk_buff *skb, struct genl_info *info) | |||
782 | struct datapath *dp; | 782 | struct datapath *dp; |
783 | struct sw_flow_actions *acts = NULL; | 783 | struct sw_flow_actions *acts = NULL; |
784 | struct sw_flow_match match; | 784 | struct sw_flow_match match; |
785 | bool exact_5tuple; | ||
786 | int error; | 785 | int error; |
787 | 786 | ||
788 | /* Extract key. */ | 787 | /* Extract key. */ |
@@ -791,7 +790,7 @@ static int ovs_flow_cmd_new_or_set(struct sk_buff *skb, struct genl_info *info) | |||
791 | goto error; | 790 | goto error; |
792 | 791 | ||
793 | ovs_match_init(&match, &key, &mask); | 792 | ovs_match_init(&match, &key, &mask); |
794 | error = ovs_nla_get_match(&match, &exact_5tuple, | 793 | error = ovs_nla_get_match(&match, |
795 | a[OVS_FLOW_ATTR_KEY], a[OVS_FLOW_ATTR_MASK]); | 794 | a[OVS_FLOW_ATTR_KEY], a[OVS_FLOW_ATTR_MASK]); |
796 | if (error) | 795 | if (error) |
797 | goto error; | 796 | goto error; |
@@ -830,7 +829,7 @@ static int ovs_flow_cmd_new_or_set(struct sk_buff *skb, struct genl_info *info) | |||
830 | goto err_unlock_ovs; | 829 | goto err_unlock_ovs; |
831 | 830 | ||
832 | /* Allocate flow. */ | 831 | /* Allocate flow. */ |
833 | flow = ovs_flow_alloc(!exact_5tuple); | 832 | flow = ovs_flow_alloc(); |
834 | if (IS_ERR(flow)) { | 833 | if (IS_ERR(flow)) { |
835 | error = PTR_ERR(flow); | 834 | error = PTR_ERR(flow); |
836 | goto err_unlock_ovs; | 835 | goto err_unlock_ovs; |
@@ -914,7 +913,7 @@ static int ovs_flow_cmd_get(struct sk_buff *skb, struct genl_info *info) | |||
914 | } | 913 | } |
915 | 914 | ||
916 | ovs_match_init(&match, &key, NULL); | 915 | ovs_match_init(&match, &key, NULL); |
917 | err = ovs_nla_get_match(&match, NULL, a[OVS_FLOW_ATTR_KEY], NULL); | 916 | err = ovs_nla_get_match(&match, a[OVS_FLOW_ATTR_KEY], NULL); |
918 | if (err) | 917 | if (err) |
919 | return err; | 918 | return err; |
920 | 919 | ||
@@ -968,7 +967,7 @@ static int ovs_flow_cmd_del(struct sk_buff *skb, struct genl_info *info) | |||
968 | } | 967 | } |
969 | 968 | ||
970 | ovs_match_init(&match, &key, NULL); | 969 | ovs_match_init(&match, &key, NULL); |
971 | err = ovs_nla_get_match(&match, NULL, a[OVS_FLOW_ATTR_KEY], NULL); | 970 | err = ovs_nla_get_match(&match, a[OVS_FLOW_ATTR_KEY], NULL); |
972 | if (err) | 971 | if (err) |
973 | goto unlock; | 972 | goto unlock; |
974 | 973 | ||