aboutsummaryrefslogtreecommitdiffstats
path: root/net/netlink/genetlink.c
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2007-09-16 19:24:44 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2007-10-10 19:51:24 -0400
commit0cfad07555312468296ea3bbbcdf99038f58678b (patch)
treea95c432bcafaf22e965dcaf27bfd4a61723d1d64 /net/netlink/genetlink.c
parent007e3936bdaaa012483c9fe06ca71c272458c710 (diff)
[NETLINK]: Avoid pointer in netlink_run_queue
I was looking at Patrick's fix to inet_diag and it occured to me that we're using a pointer argument to return values unnecessarily in netlink_run_queue. Changing it to return the value will allow the compiler to generate better code since the value won't have to be memory-backed. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netlink/genetlink.c')
-rw-r--r--net/netlink/genetlink.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
index af8fe26815fa..07ef5d204a0f 100644
--- a/net/netlink/genetlink.c
+++ b/net/netlink/genetlink.c
@@ -485,7 +485,7 @@ static void genl_rcv(struct sock *sk, int len)
485 do { 485 do {
486 if (genl_trylock()) 486 if (genl_trylock())
487 return; 487 return;
488 netlink_run_queue(sk, &qlen, genl_rcv_msg); 488 qlen = netlink_run_queue(sk, qlen, genl_rcv_msg);
489 genl_unlock(); 489 genl_unlock();
490 } while (qlen && genl_sock && genl_sock->sk_receive_queue.qlen); 490 } while (qlen && genl_sock && genl_sock->sk_receive_queue.qlen);
491} 491}