diff options
| author | Bjørn Mork <bjorn@mork.no> | 2010-05-05 23:44:34 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-05-07 00:49:59 -0400 |
| commit | ccc2d97cb7c798e785c9f198de243e2b59f7073b (patch) | |
| tree | c8752bd5a4fb051690ecaf9015fd0de2bb83560e /net/netlabel | |
| parent | 80ea76bb2575c426154b8d61d324197ee3592baa (diff) | |
ipv4: udp: fix short packet and bad checksum logging
commit 2783ef23 moved the initialisation of saddr and daddr after
pskb_may_pull() to avoid a potential data corruption. Unfortunately
also placing it after the short packet and bad checksum error paths,
where these variables are used for logging. The result is bogus
output like
[92238.389505] UDP: short packet: From 2.0.0.0:65535 23715/178 to 0.0.0.0:65535
Moving the saddr and daddr initialisation above the error paths, while still
keeping it after the pskb_may_pull() to keep the fix from commit 2783ef23.
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Cc: stable@kernel.org
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netlabel')
0 files changed, 0 insertions, 0 deletions