diff options
author | Herbert Xu <herbert@gondor.apana.org.au> | 2007-09-16 19:24:44 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 19:51:24 -0400 |
commit | 0cfad07555312468296ea3bbbcdf99038f58678b (patch) | |
tree | a95c432bcafaf22e965dcaf27bfd4a61723d1d64 /net/netfilter | |
parent | 007e3936bdaaa012483c9fe06ca71c272458c710 (diff) |
[NETLINK]: Avoid pointer in netlink_run_queue
I was looking at Patrick's fix to inet_diag and it occured
to me that we're using a pointer argument to return values
unnecessarily in netlink_run_queue. Changing it to return
the value will allow the compiler to generate better code
since the value won't have to be memory-backed.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netfilter')
-rw-r--r-- | net/netfilter/nfnetlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c index fa974e8e0ce6..4aa56e7ff156 100644 --- a/net/netfilter/nfnetlink.c +++ b/net/netfilter/nfnetlink.c | |||
@@ -248,7 +248,7 @@ static void nfnetlink_rcv(struct sock *sk, int len) | |||
248 | do { | 248 | do { |
249 | if (nfnl_trylock()) | 249 | if (nfnl_trylock()) |
250 | return; | 250 | return; |
251 | netlink_run_queue(sk, &qlen, nfnetlink_rcv_msg); | 251 | qlen = netlink_run_queue(sk, qlen, nfnetlink_rcv_msg); |
252 | __nfnl_unlock(); | 252 | __nfnl_unlock(); |
253 | } while (qlen); | 253 | } while (qlen); |
254 | } | 254 | } |