diff options
author | Michael Wu <flamingice@sourmilk.net> | 2007-12-25 19:33:16 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:09:42 -0500 |
commit | 2bc454b0b30b3645d114689b64321cb49be99923 (patch) | |
tree | a6c2bc87e02586f43a71dbb5f1808079df120dec /net/mac80211/rc80211_pid_algo.c | |
parent | 9ab461732a3cd8e7a7cf13cc46ed4c1ac7907824 (diff) |
mac80211: Fix rate reporting regression
Mattias Nissler's "clean up rate selection" patch incorrectly changes
the behavior of txrate setting in sta_info. This patch backs out parts
of the rate selection consolidation in order to fix this issue for now.
Signed-off-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/mac80211/rc80211_pid_algo.c')
-rw-r--r-- | net/mac80211/rc80211_pid_algo.c | 20 |
1 files changed, 17 insertions, 3 deletions
diff --git a/net/mac80211/rc80211_pid_algo.c b/net/mac80211/rc80211_pid_algo.c index 66cae53a647d..962286d893d6 100644 --- a/net/mac80211/rc80211_pid_algo.c +++ b/net/mac80211/rc80211_pid_algo.c | |||
@@ -310,22 +310,36 @@ static void rate_control_pid_get_rate(void *priv, struct net_device *dev, | |||
310 | { | 310 | { |
311 | struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr); | 311 | struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr); |
312 | struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data; | 312 | struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data; |
313 | struct ieee80211_sub_if_data *sdata; | ||
313 | struct sta_info *sta; | 314 | struct sta_info *sta; |
314 | int rateidx; | 315 | int rateidx; |
316 | u16 fc; | ||
315 | 317 | ||
316 | sta = sta_info_get(local, hdr->addr1); | 318 | sta = sta_info_get(local, hdr->addr1); |
317 | 319 | ||
318 | if (!sta) { | 320 | /* Send management frames and broadcast/multicast data using lowest |
319 | sel->rate = rate_lowest(local, mode, NULL); | 321 | * rate. */ |
320 | sta_info_put(sta); | 322 | fc = le16_to_cpu(hdr->frame_control); |
323 | if ((fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA || | ||
324 | is_multicast_ether_addr(hdr->addr1) || !sta) { | ||
325 | sel->rate = rate_lowest(local, mode, sta); | ||
326 | if (sta) | ||
327 | sta_info_put(sta); | ||
321 | return; | 328 | return; |
322 | } | 329 | } |
323 | 330 | ||
331 | /* If a forced rate is in effect, select it. */ | ||
332 | sdata = IEEE80211_DEV_TO_SUB_IF(dev); | ||
333 | if (sdata->bss && sdata->bss->force_unicast_rateidx > -1) | ||
334 | sta->txrate = sdata->bss->force_unicast_rateidx; | ||
335 | |||
324 | rateidx = sta->txrate; | 336 | rateidx = sta->txrate; |
325 | 337 | ||
326 | if (rateidx >= mode->num_rates) | 338 | if (rateidx >= mode->num_rates) |
327 | rateidx = mode->num_rates - 1; | 339 | rateidx = mode->num_rates - 1; |
328 | 340 | ||
341 | sta->last_txrate = rateidx; | ||
342 | |||
329 | sta_info_put(sta); | 343 | sta_info_put(sta); |
330 | 344 | ||
331 | sel->rate = &mode->rates[rateidx]; | 345 | sel->rate = &mode->rates[rateidx]; |