diff options
author | Thomas Pedersen <thomas@cozybit.com> | 2012-03-05 18:31:48 -0500 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2012-03-06 15:16:17 -0500 |
commit | 6b62bf326393deede630731a933713de9d574128 (patch) | |
tree | 73d17abe9a0c55938dae6378bab61dc82343881a /net/mac80211/mesh_hwmp.c | |
parent | 8097e1494459a4f9cdbaba7440334d9bd11a39f0 (diff) |
mac80211: fix mesh airtime link metric estimating
Airtime link metric estimation was broken in HT mesh, use
cfg80211_calculate_bitrate to get the right rate value.
Also factor out tx rate copying from sta_set_sinfo().
Signed-off-by: Thomas Pedersen <thomas@cozybit.com>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/mac80211/mesh_hwmp.c')
-rw-r--r-- | net/mac80211/mesh_hwmp.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c index 4a993f2d1ae1..1c6f3d02aebf 100644 --- a/net/mac80211/mesh_hwmp.c +++ b/net/mac80211/mesh_hwmp.c | |||
@@ -324,6 +324,7 @@ static u32 airtime_link_metric_get(struct ieee80211_local *local, | |||
324 | struct sta_info *sta) | 324 | struct sta_info *sta) |
325 | { | 325 | { |
326 | struct ieee80211_supported_band *sband; | 326 | struct ieee80211_supported_band *sband; |
327 | struct rate_info rinfo; | ||
327 | /* This should be adjusted for each device */ | 328 | /* This should be adjusted for each device */ |
328 | int device_constant = 1 << ARITH_SHIFT; | 329 | int device_constant = 1 << ARITH_SHIFT; |
329 | int test_frame_len = TEST_FRAME_LEN << ARITH_SHIFT; | 330 | int test_frame_len = TEST_FRAME_LEN << ARITH_SHIFT; |
@@ -337,7 +338,9 @@ static u32 airtime_link_metric_get(struct ieee80211_local *local, | |||
337 | if (sta->fail_avg >= 100) | 338 | if (sta->fail_avg >= 100) |
338 | return MAX_METRIC; | 339 | return MAX_METRIC; |
339 | 340 | ||
340 | if (sta->last_tx_rate.flags & IEEE80211_TX_RC_MCS) | 341 | sta_set_rate_info_tx(sta, &sta->last_tx_rate, &rinfo); |
342 | rate = cfg80211_calculate_bitrate(&rinfo); | ||
343 | if (WARN_ON(!rate)) | ||
341 | return MAX_METRIC; | 344 | return MAX_METRIC; |
342 | 345 | ||
343 | err = (sta->fail_avg << ARITH_SHIFT) / 100; | 346 | err = (sta->fail_avg << ARITH_SHIFT) / 100; |
@@ -345,7 +348,6 @@ static u32 airtime_link_metric_get(struct ieee80211_local *local, | |||
345 | /* bitrate is in units of 100 Kbps, while we need rate in units of | 348 | /* bitrate is in units of 100 Kbps, while we need rate in units of |
346 | * 1Mbps. This will be corrected on tx_time computation. | 349 | * 1Mbps. This will be corrected on tx_time computation. |
347 | */ | 350 | */ |
348 | rate = sband->bitrates[sta->last_tx_rate.idx].bitrate; | ||
349 | tx_time = (device_constant + 10 * test_frame_len / rate); | 351 | tx_time = (device_constant + 10 * test_frame_len / rate); |
350 | estimated_retx = ((1 << (2 * ARITH_SHIFT)) / (s_unit - err)); | 352 | estimated_retx = ((1 << (2 * ARITH_SHIFT)) / (s_unit - err)); |
351 | result = (tx_time * estimated_retx) >> (2 * ARITH_SHIFT) ; | 353 | result = (tx_time * estimated_retx) >> (2 * ARITH_SHIFT) ; |