aboutsummaryrefslogtreecommitdiffstats
path: root/net/mac80211/main.c
diff options
context:
space:
mode:
authorLuis R. Rodriguez <lrodriguez@atheros.com>2008-11-14 17:44:22 -0500
committerJohn W. Linville <linville@tuxdriver.com>2008-11-25 16:41:40 -0500
commit4ada424db196c78746fec255d493cacb1c9feddf (patch)
tree8fc36e480aa46b8cfebd6aff95b8d1a40b910f33 /net/mac80211/main.c
parent4d3601b234a51fdd268c8ef8068d239e26dd7ef1 (diff)
mac80211: don't assume driver has been attached on registration
mac80211's ieee80211_register_hw() is often called within the probe path so it cannot assume the device's driver structure has been attached yet so to create a workqueue instead of using driver->name use the wiphy's phy%d name. The name doesn't really matter anyway. This should fix sporadic oopses found when we race to beat the driver pointer setting. Not even sure how this was working properly. http://www.kerneloops.org/search.php?search=ieee80211_register_hw Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com> Acked-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/mac80211/main.c')
-rw-r--r--net/mac80211/main.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/net/mac80211/main.c b/net/mac80211/main.c
index d631dc96c323..cec9b6d3e1ce 100644
--- a/net/mac80211/main.c
+++ b/net/mac80211/main.c
@@ -722,7 +722,6 @@ EXPORT_SYMBOL(ieee80211_alloc_hw);
722int ieee80211_register_hw(struct ieee80211_hw *hw) 722int ieee80211_register_hw(struct ieee80211_hw *hw)
723{ 723{
724 struct ieee80211_local *local = hw_to_local(hw); 724 struct ieee80211_local *local = hw_to_local(hw);
725 const char *name;
726 int result; 725 int result;
727 enum ieee80211_band band; 726 enum ieee80211_band band;
728 struct net_device *mdev; 727 struct net_device *mdev;
@@ -787,8 +786,8 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
787 mdev->header_ops = &ieee80211_header_ops; 786 mdev->header_ops = &ieee80211_header_ops;
788 mdev->set_multicast_list = ieee80211_master_set_multicast_list; 787 mdev->set_multicast_list = ieee80211_master_set_multicast_list;
789 788
790 name = wiphy_dev(local->hw.wiphy)->driver->name; 789 local->hw.workqueue =
791 local->hw.workqueue = create_freezeable_workqueue(name); 790 create_freezeable_workqueue(wiphy_name(local->hw.wiphy));
792 if (!local->hw.workqueue) { 791 if (!local->hw.workqueue) {
793 result = -ENOMEM; 792 result = -ENOMEM;
794 goto fail_workqueue; 793 goto fail_workqueue;