diff options
| author | Eric Dumazet <dada1@cosmosbay.com> | 2005-12-22 15:49:22 -0500 |
|---|---|---|
| committer | David S. Miller <davem@sunset.davemloft.net> | 2006-01-03 16:11:15 -0500 |
| commit | 90ddc4f0470427df306f308ad03db6b6b21644b8 (patch) | |
| tree | f97c1d57b25585394ebbd4b42b8d42a339f98644 /net/key | |
| parent | 77d76ea310b50a9c8ff15bd290fcb4ed4961adf2 (diff) | |
[NET]: move struct proto_ops to const
I noticed that some of 'struct proto_ops' used in the kernel may share
a cache line used by locks or other heavily modified data. (default
linker alignement is 32 bytes, and L1_CACHE_LINE is 64 or 128 at
least)
This patch makes sure a 'struct proto_ops' can be declared as const,
so that all cpus can share all parts of it without false sharing.
This is not mandatory : a driver can still use a read/write structure
if it needs to (and eventually a __read_mostly)
I made a global stubstitute to change all existing occurences to make
them const.
This should reduce the possibility of false sharing on SMP, and
speedup some socket system calls.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/key')
| -rw-r--r-- | net/key/af_key.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/key/af_key.c b/net/key/af_key.c index d32f7791f1e4..52efd04cbedb 100644 --- a/net/key/af_key.c +++ b/net/key/af_key.c | |||
| @@ -113,7 +113,7 @@ static __inline__ void pfkey_unlock_table(void) | |||
| 113 | } | 113 | } |
| 114 | 114 | ||
| 115 | 115 | ||
| 116 | static struct proto_ops pfkey_ops; | 116 | static const struct proto_ops pfkey_ops; |
| 117 | 117 | ||
| 118 | static void pfkey_insert(struct sock *sk) | 118 | static void pfkey_insert(struct sock *sk) |
| 119 | { | 119 | { |
| @@ -3127,7 +3127,7 @@ out: | |||
| 3127 | return err; | 3127 | return err; |
| 3128 | } | 3128 | } |
| 3129 | 3129 | ||
| 3130 | static struct proto_ops pfkey_ops = { | 3130 | static const struct proto_ops pfkey_ops = { |
| 3131 | .family = PF_KEY, | 3131 | .family = PF_KEY, |
| 3132 | .owner = THIS_MODULE, | 3132 | .owner = THIS_MODULE, |
| 3133 | /* Operations that make no sense on pfkey sockets. */ | 3133 | /* Operations that make no sense on pfkey sockets. */ |
