diff options
author | Joe Perches <joe@perches.com> | 2014-11-11 16:37:30 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-11-11 18:11:00 -0500 |
commit | 6c91023dc35c88d5e6aebe4bfe6f1ed5ec2b84be (patch) | |
tree | 2f33e40962dd622ae926ff7e8284f3ef540d3ca9 /net/irda/irlap.c | |
parent | 09626e9d153326ca82568e4e27f2daa53713992e (diff) |
irda: Remove IRDA_<TYPE> logging macros
And use the more common mechanisms directly.
Other miscellanea:
o Coalesce formats
o Add missing newlines
o Realign arguments
o Remove unnecessary OOM message logging as
there's a generic stack dump already on OOM.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/irda/irlap.c')
-rw-r--r-- | net/irda/irlap.c | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/net/irda/irlap.c b/net/irda/irlap.c index a778df55f5d6..2e3bc6ccf4b5 100644 --- a/net/irda/irlap.c +++ b/net/irda/irlap.c | |||
@@ -85,8 +85,8 @@ int __init irlap_init(void) | |||
85 | /* Allocate master array */ | 85 | /* Allocate master array */ |
86 | irlap = hashbin_new(HB_LOCK); | 86 | irlap = hashbin_new(HB_LOCK); |
87 | if (irlap == NULL) { | 87 | if (irlap == NULL) { |
88 | IRDA_ERROR("%s: can't allocate irlap hashbin!\n", | 88 | net_err_ratelimited("%s: can't allocate irlap hashbin!\n", |
89 | __func__); | 89 | __func__); |
90 | return -ENOMEM; | 90 | return -ENOMEM; |
91 | } | 91 | } |
92 | 92 | ||
@@ -491,7 +491,8 @@ void irlap_disconnect_indication(struct irlap_cb *self, LAP_REASON reason) | |||
491 | reason, NULL); | 491 | reason, NULL); |
492 | break; | 492 | break; |
493 | default: | 493 | default: |
494 | IRDA_ERROR("%s: Unknown reason %d\n", __func__, reason); | 494 | net_err_ratelimited("%s: Unknown reason %d\n", |
495 | __func__, reason); | ||
495 | } | 496 | } |
496 | } | 497 | } |
497 | 498 | ||
@@ -540,8 +541,8 @@ void irlap_discovery_request(struct irlap_cb *self, discovery_t *discovery) | |||
540 | self->discovery_log = hashbin_new(HB_NOLOCK); | 541 | self->discovery_log = hashbin_new(HB_NOLOCK); |
541 | 542 | ||
542 | if (self->discovery_log == NULL) { | 543 | if (self->discovery_log == NULL) { |
543 | IRDA_WARNING("%s(), Unable to allocate discovery log!\n", | 544 | net_warn_ratelimited("%s(), Unable to allocate discovery log!\n", |
544 | __func__); | 545 | __func__); |
545 | return; | 546 | return; |
546 | } | 547 | } |
547 | 548 | ||
@@ -625,10 +626,10 @@ void irlap_status_indication(struct irlap_cb *self, int quality_of_link) | |||
625 | { | 626 | { |
626 | switch (quality_of_link) { | 627 | switch (quality_of_link) { |
627 | case STATUS_NO_ACTIVITY: | 628 | case STATUS_NO_ACTIVITY: |
628 | IRDA_MESSAGE("IrLAP, no activity on link!\n"); | 629 | net_info_ratelimited("IrLAP, no activity on link!\n"); |
629 | break; | 630 | break; |
630 | case STATUS_NOISY: | 631 | case STATUS_NOISY: |
631 | IRDA_MESSAGE("IrLAP, noisy link!\n"); | 632 | net_info_ratelimited("IrLAP, noisy link!\n"); |
632 | break; | 633 | break; |
633 | default: | 634 | default: |
634 | break; | 635 | break; |