net: Convert LIMIT_NETDEBUG to net_dbg_ratelimited

Use the more common dynamic_debug capable net_dbg_ratelimited
and remove the LIMIT_NETDEBUG macro.

All messages are still ratelimited.

Some KERN_<LEVEL> uses are changed to KERN_DEBUG.

This may have some negative impact on messages that were
emitted at KERN_INFO that are not not enabled at all unless
DEBUG is defined or dynamic_debug is enabled.  Even so,
these messages are now _not_ emitted by default.

This also eliminates the use of the net_msg_warn sysctl
"/proc/sys/net/core/warnings".  For backward compatibility,
the sysctl is not removed, but it has no function.  The extern
declaration of net_msg_warn is removed from sock.h and made
static in net/core/sysctl_net_core.c

Miscellanea:

o Update the sysctl documentation
o Remove the embedded uses of pr_fmt
o Coalesce format fragments
o Realign arguments

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

9 files changed, 45 insertions, 53 deletions

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 06e897832a7a..251fcb48b216 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1411,10 +1411,8 @@ int ipv6_dev_get_saddr(struct net *net, const struct net_device *dst_dev,
 
                         if (unlikely(score->addr_type == IPV6_ADDR_ANY ||
                                      score->addr_type & IPV6_ADDR_MULTICAST)) {
-                                LIMIT_NETDEBUG(KERN_DEBUG
-                                               "ADDRCONF: unspecified / multicast address "
-                                               "assigned as unicast address on %s",
-                                               dev->name);
+                                net_dbg_ratelimited("ADDRCONF: unspecified / multicast address assigned as unicast address on %s",
+                                                    dev->name);
                                 continue;
                         }
 
diff --git a/net/ipv6/ah6.c b/net/ipv6/ah6.c
index 6d16eb0e0c7f..8ab1989198f6 100644
--- a/net/ipv6/ah6.c
+++ b/net/ipv6/ah6.c
@@ -272,10 +272,9 @@ static int ipv6_clear_mutable_options(struct ipv6hdr *iph, int len, int dir)
                                 ipv6_rearrange_destopt(iph, exthdr.opth);
                 case NEXTHDR_HOP:
                         if (!zero_out_mutable_opts(exthdr.opth)) {
-                                LIMIT_NETDEBUG(
-                                        KERN_WARNING "overrun %sopts\n",
-                                        nexthdr == NEXTHDR_HOP ?
-                                                "hop" : "dest");
+                                net_dbg_ratelimited("overrun %sopts\n",
+                                                    nexthdr == NEXTHDR_HOP ?
+                                                    "hop" : "dest");
                                 return -EINVAL;
                         }
                         break;
diff --git a/net/ipv6/datagram.c b/net/ipv6/datagram.c
index 5c6996e44b14..cc1139687fd7 100644
--- a/net/ipv6/datagram.c
+++ b/net/ipv6/datagram.c
@@ -893,8 +893,8 @@ int ip6_datagram_send_ctl(struct net *net, struct sock *sk,
                         break;
                     }
                 default:
-                        LIMIT_NETDEBUG(KERN_DEBUG "invalid cmsg type: %d\n",
-                                       cmsg->cmsg_type);
+                        net_dbg_ratelimited("invalid cmsg type: %d\n",
+                                            cmsg->cmsg_type);
                         err = -EINVAL;
                         goto exit_f;
                 }
diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c
index d21d7b22eebc..d2c2d749b6db 100644
--- a/net/ipv6/esp6.c
+++ b/net/ipv6/esp6.c
@@ -286,8 +286,8 @@ static int esp_input_done2(struct sk_buff *skb, int err)
         err = -EINVAL;
         padlen = nexthdr[0];
         if (padlen + 2 + alen >= elen) {
-                LIMIT_NETDEBUG(KERN_WARNING "ipsec esp packet is garbage "
-                               "padlen=%d, elen=%d\n", padlen + 2, elen - alen);
+                net_dbg_ratelimited("ipsec esp packet is garbage padlen=%d, elen=%d\n",
+                                    padlen + 2, elen - alen);
                 goto out;
         }
 
diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
index 601d896f22d0..a7bbbe45570b 100644
--- a/net/ipv6/exthdrs.c
+++ b/net/ipv6/exthdrs.c
@@ -184,7 +184,7 @@ static bool ipv6_dest_hao(struct sk_buff *skb, int optoff)
         int ret;
 
         if (opt->dsthao) {
-                LIMIT_NETDEBUG(KERN_DEBUG "hao duplicated\n");
+                net_dbg_ratelimited("hao duplicated\n");
                 goto discard;
         }
         opt->dsthao = opt->dst1;
@@ -193,14 +193,14 @@ static bool ipv6_dest_hao(struct sk_buff *skb, int optoff)
         hao = (struct ipv6_destopt_hao *)(skb_network_header(skb) + optoff);
 
         if (hao->length != 16) {
-                LIMIT_NETDEBUG(
-                        KERN_DEBUG "hao invalid option length = %d\n", hao->length);
+                net_dbg_ratelimited("hao invalid option length = %d\n",
+                                    hao->length);
                 goto discard;
         }
 
         if (!(ipv6_addr_type(&hao->addr) & IPV6_ADDR_UNICAST)) {
-                LIMIT_NETDEBUG(
-                        KERN_DEBUG "hao is not an unicast addr: %pI6\n", &hao->addr);
+                net_dbg_ratelimited("hao is not an unicast addr: %pI6\n",
+                                    &hao->addr);
                 goto discard;
         }
 
@@ -551,8 +551,8 @@ static bool ipv6_hop_ra(struct sk_buff *skb, int optoff)
                 memcpy(&IP6CB(skb)->ra, nh + optoff + 2, sizeof(IP6CB(skb)->ra));
                 return true;
         }
-        LIMIT_NETDEBUG(KERN_DEBUG "ipv6_hop_ra: wrong RA length %d\n",
-                       nh[optoff + 1]);
+        net_dbg_ratelimited("ipv6_hop_ra: wrong RA length %d\n",
+                            nh[optoff + 1]);
         kfree_skb(skb);
         return false;
 }
@@ -566,8 +566,8 @@ static bool ipv6_hop_jumbo(struct sk_buff *skb, int optoff)
         u32 pkt_len;
 
         if (nh[optoff + 1] != 4 || (optoff & 3) != 2) {
-                LIMIT_NETDEBUG(KERN_DEBUG "ipv6_hop_jumbo: wrong jumbo opt length/alignment %d\n",
-                               nh[optoff+1]);
+                net_dbg_ratelimited("ipv6_hop_jumbo: wrong jumbo opt length/alignment %d\n",
+                                    nh[optoff+1]);
                 IP6_INC_STATS_BH(net, ipv6_skb_idev(skb),
                                  IPSTATS_MIB_INHDRERRORS);
                 goto drop;
diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
index 62c1037d9e83..092934032077 100644
--- a/net/ipv6/icmp.c
+++ b/net/ipv6/icmp.c
@@ -338,7 +338,7 @@ static struct dst_entry *icmpv6_route_lookup(struct net *net,
          * anycast.
          */
         if (((struct rt6_info *)dst)->rt6i_flags & RTF_ANYCAST) {
-                LIMIT_NETDEBUG(KERN_DEBUG "icmp6_send: acast source\n");
+                net_dbg_ratelimited("icmp6_send: acast source\n");
                 dst_release(dst);
                 return ERR_PTR(-EINVAL);
         }
@@ -452,7 +452,7 @@ static void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info)
          *      and anycast addresses will be checked later.
          */
         if ((addr_type == IPV6_ADDR_ANY) || (addr_type & IPV6_ADDR_MULTICAST)) {
-                LIMIT_NETDEBUG(KERN_DEBUG "icmp6_send: addr_any/mcast source\n");
+                net_dbg_ratelimited("icmp6_send: addr_any/mcast source\n");
                 return;
         }
 
@@ -460,7 +460,7 @@ static void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info)
          *      Never answer to a ICMP packet.
          */
         if (is_ineligible(skb)) {
-                LIMIT_NETDEBUG(KERN_DEBUG "icmp6_send: no reply to icmp error\n");
+                net_dbg_ratelimited("icmp6_send: no reply to icmp error\n");
                 return;
         }
 
@@ -509,7 +509,7 @@ static void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info)
         len = skb->len - msg.offset;
         len = min_t(unsigned int, len, IPV6_MIN_MTU - sizeof(struct ipv6hdr) - sizeof(struct icmp6hdr));
         if (len < 0) {
-                LIMIT_NETDEBUG(KERN_DEBUG "icmp: len problem\n");
+                net_dbg_ratelimited("icmp: len problem\n");
                 goto out_dst_release;
         }
 
@@ -706,9 +706,8 @@ static int icmpv6_rcv(struct sk_buff *skb)
         daddr = &ipv6_hdr(skb)->daddr;
 
         if (skb_checksum_validate(skb, IPPROTO_ICMPV6, ip6_compute_pseudo)) {
-                LIMIT_NETDEBUG(KERN_DEBUG
-                               "ICMPv6 checksum failed [%pI6c > %pI6c]\n",
-                               saddr, daddr);
+                net_dbg_ratelimited("ICMPv6 checksum failed [%pI6c > %pI6c]\n",
+                                    saddr, daddr);
                 goto csum_error;
         }
 
@@ -781,7 +780,7 @@ static int icmpv6_rcv(struct sk_buff *skb)
                 if (type & ICMPV6_INFOMSG_MASK)
                         break;
 
-                LIMIT_NETDEBUG(KERN_DEBUG "icmpv6: msg of unknown type\n");
+                net_dbg_ratelimited("icmpv6: msg of unknown type\n");
 
                 /*
                  * error of unknown type.
diff --git a/net/ipv6/mip6.c b/net/ipv6/mip6.c
index f61429d391d3..b9779d441b12 100644
--- a/net/ipv6/mip6.c
+++ b/net/ipv6/mip6.c
@@ -97,16 +97,17 @@ static int mip6_mh_filter(struct sock *sk, struct sk_buff *skb)
                 return -1;
 
         if (mh->ip6mh_hdrlen < mip6_mh_len(mh->ip6mh_type)) {
-                LIMIT_NETDEBUG(KERN_DEBUG "mip6: MH message too short: %d vs >=%d\n",
-                               mh->ip6mh_hdrlen, mip6_mh_len(mh->ip6mh_type));
+                net_dbg_ratelimited("mip6: MH message too short: %d vs >=%d\n",
+                                    mh->ip6mh_hdrlen,
+                                    mip6_mh_len(mh->ip6mh_type));
                 mip6_param_prob(skb, 0, offsetof(struct ip6_mh, ip6mh_hdrlen) +
                                 skb_network_header_len(skb));
                 return -1;
         }
 
         if (mh->ip6mh_proto != IPPROTO_NONE) {
-                LIMIT_NETDEBUG(KERN_DEBUG "mip6: MH invalid payload proto = %d\n",
-                               mh->ip6mh_proto);
+                net_dbg_ratelimited("mip6: MH invalid payload proto = %d\n",
+                                    mh->ip6mh_proto);
                 mip6_param_prob(skb, 0, offsetof(struct ip6_mh, ip6mh_proto) +
                                 skb_network_header_len(skb));
                 return -1;
@@ -288,7 +289,7 @@ static int mip6_destopt_offset(struct xfrm_state *x, struct sk_buff *skb,
                          * XXX: packet if HAO exists.
                          */
                         if (ipv6_find_tlv(skb, offset, IPV6_TLV_HAO) >= 0) {
-                                LIMIT_NETDEBUG(KERN_WARNING "mip6: hao exists already, override\n");
+                                net_dbg_ratelimited("mip6: hao exists already, override\n");
                                 return offset;
                         }
 
diff --git a/net/ipv6/netfilter.c b/net/ipv6/netfilter.c
index d38e6a8d8b9f..398377a9d018 100644
--- a/net/ipv6/netfilter.c
+++ b/net/ipv6/netfilter.c
@@ -36,7 +36,7 @@ int ip6_route_me_harder(struct sk_buff *skb)
         err = dst->error;
         if (err) {
                 IP6_INC_STATS(net, ip6_dst_idev(dst), IPSTATS_MIB_OUTNOROUTES);
-                LIMIT_NETDEBUG(KERN_DEBUG "ip6_route_me_harder: No more route.\n");
+                net_dbg_ratelimited("ip6_route_me_harder: No more route\n");
                 dst_release(dst);
                 return err;
         }
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
index d1fe36274906..0ba3de4f2368 100644
--- a/net/ipv6/udp.c
+++ b/net/ipv6/udp.c
@@ -660,15 +660,13 @@ int udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
         if ((is_udplite & UDPLITE_RECV_CC)  &&  UDP_SKB_CB(skb)->partial_cov) {
 
                 if (up->pcrlen == 0) {          /* full coverage was set  */
-                        LIMIT_NETDEBUG(KERN_WARNING "UDPLITE6: partial coverage"
-                                " %d while full coverage %d requested\n",
-                                UDP_SKB_CB(skb)->cscov, skb->len);
+                        net_dbg_ratelimited("UDPLITE6: partial coverage %d while full coverage %d requested\n",
+                                            UDP_SKB_CB(skb)->cscov, skb->len);
                         goto drop;
                 }
                 if (UDP_SKB_CB(skb)->cscov  <  up->pcrlen) {
-                        LIMIT_NETDEBUG(KERN_WARNING "UDPLITE6: coverage %d "
-                                                    "too small, need min %d\n",
-                                       UDP_SKB_CB(skb)->cscov, up->pcrlen);
+                        net_dbg_ratelimited("UDPLITE6: coverage %d too small, need min %d\n",
+                                            UDP_SKB_CB(skb)->cscov, up->pcrlen);
                         goto drop;
                 }
         }
@@ -761,9 +759,9 @@ static void udp6_csum_zero_error(struct sk_buff *skb)
         /* RFC 2460 section 8.1 says that we SHOULD log
          * this error. Well, it is reasonable.
          */
-        LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0 for [%pI6c]:%u->[%pI6c]:%u\n",
-                       &ipv6_hdr(skb)->saddr, ntohs(udp_hdr(skb)->source),
-                       &ipv6_hdr(skb)->daddr, ntohs(udp_hdr(skb)->dest));
+        net_dbg_ratelimited("IPv6: udp checksum is 0 for [%pI6c]:%u->[%pI6c]:%u\n",
+                            &ipv6_hdr(skb)->saddr, ntohs(udp_hdr(skb)->source),
+                            &ipv6_hdr(skb)->daddr, ntohs(udp_hdr(skb)->dest));
 }
 
 /*
@@ -931,14 +929,11 @@ int __udp6_lib_rcv(struct sk_buff *skb, struct udp_table *udptable,
         return 0;
 
 short_packet:
-        LIMIT_NETDEBUG(KERN_DEBUG "UDP%sv6: short packet: From [%pI6c]:%u %d/%d to [%pI6c]:%u\n",
-                       proto == IPPROTO_UDPLITE ? "-Lite" : "",
-                       saddr,
-                       ntohs(uh->source),
-                       ulen,
-                       skb->len,
-                       daddr,
-                       ntohs(uh->dest));
+        net_dbg_ratelimited("UDP%sv6: short packet: From [%pI6c]:%u %d/%d to [%pI6c]:%u\n",
+                            proto == IPPROTO_UDPLITE ? "-Lite" : "",
+                            saddr, ntohs(uh->source),
+                            ulen, skb->len,
+                            daddr, ntohs(uh->dest));
         goto discard;
 csum_error:
         UDP6_INC_STATS_BH(net, UDP_MIB_CSUMERRORS, proto == IPPROTO_UDPLITE);
@@ -1290,7 +1285,7 @@ back_from_confirm:
                 /* ... which is an evident application bug. --ANK */
                 release_sock(sk);
 
-                LIMIT_NETDEBUG(KERN_DEBUG "udp cork app bug 2\n");
+                net_dbg_ratelimited("udp cork app bug 2\n");
                 err = -EINVAL;
                 goto out;
         }