diff options
author | Florian Westphal <fw@strlen.de> | 2014-11-13 04:04:16 -0500 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2014-11-13 06:14:42 -0500 |
commit | 56768644317c7746cb63f61573fcdc2355885707 (patch) | |
tree | 4017ecc79619024d7af5d7588cb2ce5b0fb8fe83 /net/ipv6 | |
parent | baf4750d92cdfb63d6535f7166c6189d07407b65 (diff) |
netfilter: fix various sparse warnings
net/bridge/br_netfilter.c:870:6: symbol 'br_netfilter_enable' was not declared. Should it be static?
no; add include
net/ipv4/netfilter/nft_reject_ipv4.c:22:6: symbol 'nft_reject_ipv4_eval' was not declared. Should it be static?
yes
net/ipv6/netfilter/nf_reject_ipv6.c:16:6: symbol 'nf_send_reset6' was not declared. Should it be static?
no; add include
net/ipv6/netfilter/nft_reject_ipv6.c:22:6: symbol 'nft_reject_ipv6_eval' was not declared. Should it be static?
yes
net/netfilter/core.c:33:32: symbol 'nf_ipv6_ops' was not declared. Should it be static?
no; add include
net/netfilter/xt_DSCP.c:40:57: cast truncates bits from constant value (ffffff03 becomes 3)
net/netfilter/xt_DSCP.c:57:59: cast truncates bits from constant value (ffffff03 becomes 3)
add __force, 3 is what we want.
net/ipv4/netfilter/nf_log_arp.c:77:6: symbol 'nf_log_arp_packet' was not declared. Should it be static?
yes
net/ipv4/netfilter/nf_reject_ipv4.c:17:6: symbol 'nf_send_reset' was not declared. Should it be static?
no; add include
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/ipv6')
-rw-r--r-- | net/ipv6/netfilter/nf_reject_ipv6.c | 1 | ||||
-rw-r--r-- | net/ipv6/netfilter/nft_reject_ipv6.c | 7 |
2 files changed, 4 insertions, 4 deletions
diff --git a/net/ipv6/netfilter/nf_reject_ipv6.c b/net/ipv6/netfilter/nf_reject_ipv6.c index 20d9defc6c59..87576ff15e1b 100644 --- a/net/ipv6/netfilter/nf_reject_ipv6.c +++ b/net/ipv6/netfilter/nf_reject_ipv6.c | |||
@@ -11,6 +11,7 @@ | |||
11 | #include <net/ip6_route.h> | 11 | #include <net/ip6_route.h> |
12 | #include <net/ip6_fib.h> | 12 | #include <net/ip6_fib.h> |
13 | #include <net/ip6_checksum.h> | 13 | #include <net/ip6_checksum.h> |
14 | #include <net/netfilter/ipv6/nf_reject.h> | ||
14 | #include <linux/netfilter_ipv6.h> | 15 | #include <linux/netfilter_ipv6.h> |
15 | 16 | ||
16 | void nf_send_reset6(struct net *net, struct sk_buff *oldskb, int hook) | 17 | void nf_send_reset6(struct net *net, struct sk_buff *oldskb, int hook) |
diff --git a/net/ipv6/netfilter/nft_reject_ipv6.c b/net/ipv6/netfilter/nft_reject_ipv6.c index 0bc19fa87821..f73285924144 100644 --- a/net/ipv6/netfilter/nft_reject_ipv6.c +++ b/net/ipv6/netfilter/nft_reject_ipv6.c | |||
@@ -19,9 +19,9 @@ | |||
19 | #include <net/netfilter/nft_reject.h> | 19 | #include <net/netfilter/nft_reject.h> |
20 | #include <net/netfilter/ipv6/nf_reject.h> | 20 | #include <net/netfilter/ipv6/nf_reject.h> |
21 | 21 | ||
22 | void nft_reject_ipv6_eval(const struct nft_expr *expr, | 22 | static void nft_reject_ipv6_eval(const struct nft_expr *expr, |
23 | struct nft_data data[NFT_REG_MAX + 1], | 23 | struct nft_data data[NFT_REG_MAX + 1], |
24 | const struct nft_pktinfo *pkt) | 24 | const struct nft_pktinfo *pkt) |
25 | { | 25 | { |
26 | struct nft_reject *priv = nft_expr_priv(expr); | 26 | struct nft_reject *priv = nft_expr_priv(expr); |
27 | struct net *net = dev_net((pkt->in != NULL) ? pkt->in : pkt->out); | 27 | struct net *net = dev_net((pkt->in != NULL) ? pkt->in : pkt->out); |
@@ -38,7 +38,6 @@ void nft_reject_ipv6_eval(const struct nft_expr *expr, | |||
38 | 38 | ||
39 | data[NFT_REG_VERDICT].verdict = NF_DROP; | 39 | data[NFT_REG_VERDICT].verdict = NF_DROP; |
40 | } | 40 | } |
41 | EXPORT_SYMBOL_GPL(nft_reject_ipv6_eval); | ||
42 | 41 | ||
43 | static struct nft_expr_type nft_reject_ipv6_type; | 42 | static struct nft_expr_type nft_reject_ipv6_type; |
44 | static const struct nft_expr_ops nft_reject_ipv6_ops = { | 43 | static const struct nft_expr_ops nft_reject_ipv6_ops = { |