diff options
author | Eric Dumazet <edumazet@google.com> | 2015-03-25 00:45:56 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-03-25 00:57:48 -0400 |
commit | 0144a81cccf7532bead90f0542f517bd028d3b3c (patch) | |
tree | ee5dd135f364e5111388180183f9a4d4918b3ecb /net/ipv6 | |
parent | d631b94e7a15277858ec5f88d674d93080506999 (diff) |
tcp: fix ipv4 mapped request socks
ss should display ipv4 mapped request sockets like this :
tcp SYN-RECV 0 0 ::ffff:192.168.0.1:8080 ::ffff:192.0.2.1:35261
and not like this :
tcp SYN-RECV 0 0 192.168.0.1:8080 192.0.2.1:35261
We should init ireq->ireq_family based on listener sk_family,
not the actual protocol carried by SYN packet.
This means we can set ireq_family in inet_reqsk_alloc()
Fixes: 3f66b083a5b7 ("inet: introduce ireq_family")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6')
-rw-r--r-- | net/ipv6/syncookies.c | 1 | ||||
-rw-r--r-- | net/ipv6/tcp_ipv6.c | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/net/ipv6/syncookies.c b/net/ipv6/syncookies.c index 2819137fc87d..21bc2eb53c57 100644 --- a/net/ipv6/syncookies.c +++ b/net/ipv6/syncookies.c | |||
@@ -197,7 +197,6 @@ struct sock *cookie_v6_check(struct sock *sk, struct sk_buff *skb) | |||
197 | ireq = inet_rsk(req); | 197 | ireq = inet_rsk(req); |
198 | treq = tcp_rsk(req); | 198 | treq = tcp_rsk(req); |
199 | treq->tfo_listener = false; | 199 | treq->tfo_listener = false; |
200 | ireq->ireq_family = AF_INET6; | ||
201 | 200 | ||
202 | if (security_inet_conn_request(sk, skb, req)) | 201 | if (security_inet_conn_request(sk, skb, req)) |
203 | goto out_free; | 202 | goto out_free; |
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index a9568caf4675..cbdf6912d2c6 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c | |||
@@ -688,7 +688,6 @@ static void tcp_v6_init_req(struct request_sock *req, struct sock *sk, | |||
688 | atomic_inc(&skb->users); | 688 | atomic_inc(&skb->users); |
689 | ireq->pktopts = skb; | 689 | ireq->pktopts = skb; |
690 | } | 690 | } |
691 | ireq->ireq_family = AF_INET6; | ||
692 | } | 691 | } |
693 | 692 | ||
694 | static struct dst_entry *tcp_v6_route_req(struct sock *sk, struct flowi *fl, | 693 | static struct dst_entry *tcp_v6_route_req(struct sock *sk, struct flowi *fl, |