diff options
author | Eric Dumazet <dada1@cosmosbay.com> | 2005-12-22 15:49:22 -0500 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2006-01-03 16:11:15 -0500 |
commit | 90ddc4f0470427df306f308ad03db6b6b21644b8 (patch) | |
tree | f97c1d57b25585394ebbd4b42b8d42a339f98644 /net/ipv6/af_inet6.c | |
parent | 77d76ea310b50a9c8ff15bd290fcb4ed4961adf2 (diff) |
[NET]: move struct proto_ops to const
I noticed that some of 'struct proto_ops' used in the kernel may share
a cache line used by locks or other heavily modified data. (default
linker alignement is 32 bytes, and L1_CACHE_LINE is 64 or 128 at
least)
This patch makes sure a 'struct proto_ops' can be declared as const,
so that all cpus can share all parts of it without false sharing.
This is not mandatory : a driver can still use a read/write structure
if it needs to (and eventually a __read_mostly)
I made a global stubstitute to change all existing occurences to make
them const.
This should reduce the possibility of false sharing on SMP, and
speedup some socket system calls.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/af_inet6.c')
-rw-r--r-- | net/ipv6/af_inet6.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c index 70a510ff31ee..7c9f19269f21 100644 --- a/net/ipv6/af_inet6.c +++ b/net/ipv6/af_inet6.c | |||
@@ -462,7 +462,7 @@ int inet6_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) | |||
462 | return(0); | 462 | return(0); |
463 | } | 463 | } |
464 | 464 | ||
465 | struct proto_ops inet6_stream_ops = { | 465 | const struct proto_ops inet6_stream_ops = { |
466 | .family = PF_INET6, | 466 | .family = PF_INET6, |
467 | .owner = THIS_MODULE, | 467 | .owner = THIS_MODULE, |
468 | .release = inet6_release, | 468 | .release = inet6_release, |
@@ -483,7 +483,7 @@ struct proto_ops inet6_stream_ops = { | |||
483 | .sendpage = tcp_sendpage | 483 | .sendpage = tcp_sendpage |
484 | }; | 484 | }; |
485 | 485 | ||
486 | struct proto_ops inet6_dgram_ops = { | 486 | const struct proto_ops inet6_dgram_ops = { |
487 | .family = PF_INET6, | 487 | .family = PF_INET6, |
488 | .owner = THIS_MODULE, | 488 | .owner = THIS_MODULE, |
489 | .release = inet6_release, | 489 | .release = inet6_release, |
@@ -511,7 +511,7 @@ static struct net_proto_family inet6_family_ops = { | |||
511 | }; | 511 | }; |
512 | 512 | ||
513 | /* Same as inet6_dgram_ops, sans udp_poll. */ | 513 | /* Same as inet6_dgram_ops, sans udp_poll. */ |
514 | static struct proto_ops inet6_sockraw_ops = { | 514 | static const struct proto_ops inet6_sockraw_ops = { |
515 | .family = PF_INET6, | 515 | .family = PF_INET6, |
516 | .owner = THIS_MODULE, | 516 | .owner = THIS_MODULE, |
517 | .release = inet6_release, | 517 | .release = inet6_release, |