aboutsummaryrefslogtreecommitdiffstats
path: root/net/ipv4/tcp_output.c
diff options
context:
space:
mode:
authorDavid S. Miller <davem@sunset.davemloft.net>2006-11-09 22:58:25 -0500
committerDavid S. Miller <davem@sunset.davemloft.net>2006-12-03 00:21:52 -0500
commit931731123a103cfb3f70ac4b7abfc71d94ba1f03 (patch)
tree0af6636fde05f74a8aa5421bfe9828e2a209170d /net/ipv4/tcp_output.c
parentef56e622c61e74dd6077615c9ea76c5132195880 (diff)
[TCP]: Don't set SKB owner in tcp_transmit_skb().
The data itself is already charged to the SKB, doing the skb_set_owner_w() just generates a lot of noise and extra atomics we don't really need. Lmbench improvements on lat_tcp are minimal: before: TCP latency using localhost: 23.2701 microseconds TCP latency using localhost: 23.1994 microseconds TCP latency using localhost: 23.2257 microseconds after: TCP latency using localhost: 22.8380 microseconds TCP latency using localhost: 22.9465 microseconds TCP latency using localhost: 22.8462 microseconds Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_output.c')
-rw-r--r--net/ipv4/tcp_output.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index ca406157724c..f63e99aac2d5 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -426,7 +426,6 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it,
426 426
427 th = (struct tcphdr *) skb_push(skb, tcp_header_size); 427 th = (struct tcphdr *) skb_push(skb, tcp_header_size);
428 skb->h.th = th; 428 skb->h.th = th;
429 skb_set_owner_w(skb, sk);
430 429
431 /* Build TCP header and checksum it. */ 430 /* Build TCP header and checksum it. */
432 th->source = inet->sport; 431 th->source = inet->sport;
@@ -479,7 +478,7 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it,
479 if (after(tcb->end_seq, tp->snd_nxt) || tcb->seq == tcb->end_seq) 478 if (after(tcb->end_seq, tp->snd_nxt) || tcb->seq == tcb->end_seq)
480 TCP_INC_STATS(TCP_MIB_OUTSEGS); 479 TCP_INC_STATS(TCP_MIB_OUTSEGS);
481 480
482 err = icsk->icsk_af_ops->queue_xmit(skb, 0); 481 err = icsk->icsk_af_ops->queue_xmit(skb, sk, 0);
483 if (likely(err <= 0)) 482 if (likely(err <= 0))
484 return err; 483 return err;
485 484