aboutsummaryrefslogtreecommitdiffstats
path: root/net/ipv4/ip_fragment.c
diff options
context:
space:
mode:
authorNikolay Aleksandrov <nikolay@redhat.com>2014-08-01 06:29:44 -0400
committerDavid S. Miller <davem@davemloft.net>2014-08-02 18:31:31 -0400
commit06aa8b8a0345c78f4d9a1fb3f852952b12a0e40c (patch)
tree9511c6007eed4f71fe5e601688f35d6ff7dd4b9b /net/ipv4/ip_fragment.c
parentd2373862b3589260f0139a6e4969478f84154369 (diff)
inet: frags: rename last_in to flags
The last_in field has been used to store various flags different from first/last frag in so give it a more descriptive name: flags. Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_fragment.c')
-rw-r--r--net/ipv4/ip_fragment.c20
1 files changed, 10 insertions, 10 deletions
diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c
index 634fc31aa243..6fce1ecc5bca 100644
--- a/net/ipv4/ip_fragment.c
+++ b/net/ipv4/ip_fragment.c
@@ -185,16 +185,16 @@ static void ip_expire(unsigned long arg)
185 185
186 spin_lock(&qp->q.lock); 186 spin_lock(&qp->q.lock);
187 187
188 if (qp->q.last_in & INET_FRAG_COMPLETE) 188 if (qp->q.flags & INET_FRAG_COMPLETE)
189 goto out; 189 goto out;
190 190
191 ipq_kill(qp); 191 ipq_kill(qp);
192 192
193 if (!(qp->q.last_in & INET_FRAG_EVICTED)) 193 if (!(qp->q.flags & INET_FRAG_EVICTED))
194 IP_INC_STATS_BH(net, IPSTATS_MIB_REASMTIMEOUT); 194 IP_INC_STATS_BH(net, IPSTATS_MIB_REASMTIMEOUT);
195 IP_INC_STATS_BH(net, IPSTATS_MIB_REASMFAILS); 195 IP_INC_STATS_BH(net, IPSTATS_MIB_REASMFAILS);
196 196
197 if ((qp->q.last_in & INET_FRAG_FIRST_IN) && qp->q.fragments != NULL) { 197 if ((qp->q.flags & INET_FRAG_FIRST_IN) && qp->q.fragments != NULL) {
198 struct sk_buff *head = qp->q.fragments; 198 struct sk_buff *head = qp->q.fragments;
199 const struct iphdr *iph; 199 const struct iphdr *iph;
200 int err; 200 int err;
@@ -302,7 +302,7 @@ static int ip_frag_reinit(struct ipq *qp)
302 } while (fp); 302 } while (fp);
303 sub_frag_mem_limit(&qp->q, sum_truesize); 303 sub_frag_mem_limit(&qp->q, sum_truesize);
304 304
305 qp->q.last_in = 0; 305 qp->q.flags = 0;
306 qp->q.len = 0; 306 qp->q.len = 0;
307 qp->q.meat = 0; 307 qp->q.meat = 0;
308 qp->q.fragments = NULL; 308 qp->q.fragments = NULL;
@@ -323,7 +323,7 @@ static int ip_frag_queue(struct ipq *qp, struct sk_buff *skb)
323 int err = -ENOENT; 323 int err = -ENOENT;
324 u8 ecn; 324 u8 ecn;
325 325
326 if (qp->q.last_in & INET_FRAG_COMPLETE) 326 if (qp->q.flags & INET_FRAG_COMPLETE)
327 goto err; 327 goto err;
328 328
329 if (!(IPCB(skb)->flags & IPSKB_FRAG_COMPLETE) && 329 if (!(IPCB(skb)->flags & IPSKB_FRAG_COMPLETE) &&
@@ -350,9 +350,9 @@ static int ip_frag_queue(struct ipq *qp, struct sk_buff *skb)
350 * or have different end, the segment is corrupted. 350 * or have different end, the segment is corrupted.
351 */ 351 */
352 if (end < qp->q.len || 352 if (end < qp->q.len ||
353 ((qp->q.last_in & INET_FRAG_LAST_IN) && end != qp->q.len)) 353 ((qp->q.flags & INET_FRAG_LAST_IN) && end != qp->q.len))
354 goto err; 354 goto err;
355 qp->q.last_in |= INET_FRAG_LAST_IN; 355 qp->q.flags |= INET_FRAG_LAST_IN;
356 qp->q.len = end; 356 qp->q.len = end;
357 } else { 357 } else {
358 if (end&7) { 358 if (end&7) {
@@ -362,7 +362,7 @@ static int ip_frag_queue(struct ipq *qp, struct sk_buff *skb)
362 } 362 }
363 if (end > qp->q.len) { 363 if (end > qp->q.len) {
364 /* Some bits beyond end -> corruption. */ 364 /* Some bits beyond end -> corruption. */
365 if (qp->q.last_in & INET_FRAG_LAST_IN) 365 if (qp->q.flags & INET_FRAG_LAST_IN)
366 goto err; 366 goto err;
367 qp->q.len = end; 367 qp->q.len = end;
368 } 368 }
@@ -471,13 +471,13 @@ found:
471 qp->ecn |= ecn; 471 qp->ecn |= ecn;
472 add_frag_mem_limit(&qp->q, skb->truesize); 472 add_frag_mem_limit(&qp->q, skb->truesize);
473 if (offset == 0) 473 if (offset == 0)
474 qp->q.last_in |= INET_FRAG_FIRST_IN; 474 qp->q.flags |= INET_FRAG_FIRST_IN;
475 475
476 if (ip_hdr(skb)->frag_off & htons(IP_DF) && 476 if (ip_hdr(skb)->frag_off & htons(IP_DF) &&
477 skb->len + ihl > qp->q.max_size) 477 skb->len + ihl > qp->q.max_size)
478 qp->q.max_size = skb->len + ihl; 478 qp->q.max_size = skb->len + ihl;
479 479
480 if (qp->q.last_in == (INET_FRAG_FIRST_IN | INET_FRAG_LAST_IN) && 480 if (qp->q.flags == (INET_FRAG_FIRST_IN | INET_FRAG_LAST_IN) &&
481 qp->q.meat == qp->q.len) { 481 qp->q.meat == qp->q.len) {
482 unsigned long orefdst = skb->_skb_refdst; 482 unsigned long orefdst = skb->_skb_refdst;
483 483