diff options
author | Alexander Duyck <alexander.h.duyck@intel.com> | 2009-12-02 11:49:02 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-12-02 22:57:15 -0500 |
commit | c81c2d95449cd218c2022ce6014c52fef1eb1f66 (patch) | |
tree | 3da987f71e3a6807b1d48637766724412689805b /net/core | |
parent | f4188d8affc8267a0f0f1b587a4d0a4b9b7f2999 (diff) |
skbuff: remove skb_dma_map/unmap
The two functions skb_dma_map/unmap are unsafe to use as they cause
problems when packets are cloned and sent to multiple devices while a HW
IOMMU is enabled. Due to this it is best to remove the code so it is not
used by any other network driver maintainters.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
-rw-r--r-- | net/core/Makefile | 1 | ||||
-rw-r--r-- | net/core/skb_dma_map.c | 65 |
2 files changed, 0 insertions, 66 deletions
diff --git a/net/core/Makefile b/net/core/Makefile index 796f46eece5f..08791ac3e05a 100644 --- a/net/core/Makefile +++ b/net/core/Makefile | |||
@@ -6,7 +6,6 @@ obj-y := sock.o request_sock.o skbuff.o iovec.o datagram.o stream.o scm.o \ | |||
6 | gen_stats.o gen_estimator.o net_namespace.o | 6 | gen_stats.o gen_estimator.o net_namespace.o |
7 | 7 | ||
8 | obj-$(CONFIG_SYSCTL) += sysctl_net_core.o | 8 | obj-$(CONFIG_SYSCTL) += sysctl_net_core.o |
9 | obj-$(CONFIG_HAS_DMA) += skb_dma_map.o | ||
10 | 9 | ||
11 | obj-y += dev.o ethtool.o dev_mcast.o dst.o netevent.o \ | 10 | obj-y += dev.o ethtool.o dev_mcast.o dst.o netevent.o \ |
12 | neighbour.o rtnetlink.o utils.o link_watch.o filter.o | 11 | neighbour.o rtnetlink.o utils.o link_watch.o filter.o |
diff --git a/net/core/skb_dma_map.c b/net/core/skb_dma_map.c deleted file mode 100644 index 79687dfd6957..000000000000 --- a/net/core/skb_dma_map.c +++ /dev/null | |||
@@ -1,65 +0,0 @@ | |||
1 | /* skb_dma_map.c: DMA mapping helpers for socket buffers. | ||
2 | * | ||
3 | * Copyright (C) David S. Miller <davem@davemloft.net> | ||
4 | */ | ||
5 | |||
6 | #include <linux/kernel.h> | ||
7 | #include <linux/module.h> | ||
8 | #include <linux/dma-mapping.h> | ||
9 | #include <linux/skbuff.h> | ||
10 | |||
11 | int skb_dma_map(struct device *dev, struct sk_buff *skb, | ||
12 | enum dma_data_direction dir) | ||
13 | { | ||
14 | struct skb_shared_info *sp = skb_shinfo(skb); | ||
15 | dma_addr_t map; | ||
16 | int i; | ||
17 | |||
18 | map = dma_map_single(dev, skb->data, | ||
19 | skb_headlen(skb), dir); | ||
20 | if (dma_mapping_error(dev, map)) | ||
21 | goto out_err; | ||
22 | |||
23 | sp->dma_head = map; | ||
24 | for (i = 0; i < sp->nr_frags; i++) { | ||
25 | skb_frag_t *fp = &sp->frags[i]; | ||
26 | |||
27 | map = dma_map_page(dev, fp->page, fp->page_offset, | ||
28 | fp->size, dir); | ||
29 | if (dma_mapping_error(dev, map)) | ||
30 | goto unwind; | ||
31 | sp->dma_maps[i] = map; | ||
32 | } | ||
33 | |||
34 | return 0; | ||
35 | |||
36 | unwind: | ||
37 | while (--i >= 0) { | ||
38 | skb_frag_t *fp = &sp->frags[i]; | ||
39 | |||
40 | dma_unmap_page(dev, sp->dma_maps[i], | ||
41 | fp->size, dir); | ||
42 | } | ||
43 | dma_unmap_single(dev, sp->dma_head, | ||
44 | skb_headlen(skb), dir); | ||
45 | out_err: | ||
46 | return -ENOMEM; | ||
47 | } | ||
48 | EXPORT_SYMBOL(skb_dma_map); | ||
49 | |||
50 | void skb_dma_unmap(struct device *dev, struct sk_buff *skb, | ||
51 | enum dma_data_direction dir) | ||
52 | { | ||
53 | struct skb_shared_info *sp = skb_shinfo(skb); | ||
54 | int i; | ||
55 | |||
56 | dma_unmap_single(dev, sp->dma_head, | ||
57 | skb_headlen(skb), dir); | ||
58 | for (i = 0; i < sp->nr_frags; i++) { | ||
59 | skb_frag_t *fp = &sp->frags[i]; | ||
60 | |||
61 | dma_unmap_page(dev, sp->dma_maps[i], | ||
62 | fp->size, dir); | ||
63 | } | ||
64 | } | ||
65 | EXPORT_SYMBOL(skb_dma_unmap); | ||