diff options
author | David Howells <dhowells@redhat.com> | 2013-04-12 12:27:28 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2013-05-01 17:29:46 -0400 |
commit | a8ca16ea7b0abb0a7e49492d1123b715f0ec62e8 (patch) | |
tree | fe201353c71385cab2f3cc0d7235c76121f51789 /net/core | |
parent | 8d8b97ba499cb69fccb5fd9f2b439e3265fc3f27 (diff) |
proc: Supply a function to remove a proc entry by PDE
Supply a function (proc_remove()) to remove a proc entry (and any subtree
rooted there) by proc_dir_entry pointer rather than by name and (optionally)
root dir entry pointer. This allows us to eliminate all remaining pde->name
accesses outside of procfs.
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Grant Likely <grant.likely@linaro.or>
cc: linux-acpi@vger.kernel.org
cc: openipmi-developer@lists.sourceforge.net
cc: devicetree-discuss@lists.ozlabs.org
cc: linux-pci@vger.kernel.org
cc: netdev@vger.kernel.org
cc: netfilter-devel@vger.kernel.org
cc: alsa-devel@alsa-project.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'net/core')
-rw-r--r-- | net/core/pktgen.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/net/core/pktgen.c b/net/core/pktgen.c index f6af4fe59f2e..6c41e979dc88 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c | |||
@@ -1904,7 +1904,7 @@ static void pktgen_change_name(const struct pktgen_net *pn, struct net_device *d | |||
1904 | if (pkt_dev->odev != dev) | 1904 | if (pkt_dev->odev != dev) |
1905 | continue; | 1905 | continue; |
1906 | 1906 | ||
1907 | remove_proc_entry(pkt_dev->entry->name, pn->proc_dir); | 1907 | proc_remove(pkt_dev->entry); |
1908 | 1908 | ||
1909 | pkt_dev->entry = proc_create_data(dev->name, 0600, | 1909 | pkt_dev->entry = proc_create_data(dev->name, 0600, |
1910 | pn->proc_dir, | 1910 | pn->proc_dir, |
@@ -3576,8 +3576,6 @@ static void _rem_dev_from_if_list(struct pktgen_thread *t, | |||
3576 | static int pktgen_remove_device(struct pktgen_thread *t, | 3576 | static int pktgen_remove_device(struct pktgen_thread *t, |
3577 | struct pktgen_dev *pkt_dev) | 3577 | struct pktgen_dev *pkt_dev) |
3578 | { | 3578 | { |
3579 | struct pktgen_net *pn = t->net; | ||
3580 | |||
3581 | pr_debug("remove_device pkt_dev=%p\n", pkt_dev); | 3579 | pr_debug("remove_device pkt_dev=%p\n", pkt_dev); |
3582 | 3580 | ||
3583 | if (pkt_dev->running) { | 3581 | if (pkt_dev->running) { |
@@ -3597,7 +3595,7 @@ static int pktgen_remove_device(struct pktgen_thread *t, | |||
3597 | _rem_dev_from_if_list(t, pkt_dev); | 3595 | _rem_dev_from_if_list(t, pkt_dev); |
3598 | 3596 | ||
3599 | if (pkt_dev->entry) | 3597 | if (pkt_dev->entry) |
3600 | remove_proc_entry(pkt_dev->entry->name, pn->proc_dir); | 3598 | proc_remove(pkt_dev->entry); |
3601 | 3599 | ||
3602 | #ifdef CONFIG_XFRM | 3600 | #ifdef CONFIG_XFRM |
3603 | free_SAs(pkt_dev); | 3601 | free_SAs(pkt_dev); |