diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2011-12-07 15:49:38 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-12-08 19:58:35 -0500 |
commit | 6f8e4ad0eff5117ba895122674670f9c63b6e8d8 (patch) | |
tree | b84f9c6566a1d6b178b8ca2d021919b5c3499367 /net/core | |
parent | 865d9f9f748fdc1943679ea65d9ee1dc55e4a6ae (diff) |
sock_diag: off by one checks
These tests are off by one because sock_diag_handlers[] only has AF_MAX
elements.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Pavel Emelyanov <xemul@parallels.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
-rw-r--r-- | net/core/sock_diag.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/core/sock_diag.c b/net/core/sock_diag.c index fbaf01ce12f2..9c27bcda59be 100644 --- a/net/core/sock_diag.c +++ b/net/core/sock_diag.c | |||
@@ -32,7 +32,7 @@ int sock_diag_register(struct sock_diag_handler *hndl) | |||
32 | { | 32 | { |
33 | int err = 0; | 33 | int err = 0; |
34 | 34 | ||
35 | if (hndl->family > AF_MAX) | 35 | if (hndl->family >= AF_MAX) |
36 | return -EINVAL; | 36 | return -EINVAL; |
37 | 37 | ||
38 | mutex_lock(&sock_diag_table_mutex); | 38 | mutex_lock(&sock_diag_table_mutex); |
@@ -50,7 +50,7 @@ void sock_diag_unregister(struct sock_diag_handler *hnld) | |||
50 | { | 50 | { |
51 | int family = hnld->family; | 51 | int family = hnld->family; |
52 | 52 | ||
53 | if (family > AF_MAX) | 53 | if (family >= AF_MAX) |
54 | return; | 54 | return; |
55 | 55 | ||
56 | mutex_lock(&sock_diag_table_mutex); | 56 | mutex_lock(&sock_diag_table_mutex); |