diff options
author | Stephen Hemminger <shemminger@vyatta.com> | 2008-11-20 00:40:23 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-11-20 00:40:23 -0500 |
commit | eeda3fd64f75bcbfaa70ce946513abaf3f23b8e0 (patch) | |
tree | 082d1921a5783ef5b07b4cf666804d6509f25f1a /net/core/net-sysfs.c | |
parent | d314774cf2cd5dfeb39a00d37deee65d4c627927 (diff) |
netdev: introduce dev_get_stats()
In order for the network device ops get_stats call to be immutable, the handling
of the default internal network device stats block has to be changed. Add a new
helper function which replaces the old use of internal_get_stats.
Note: change return code to make it clear that the caller should not
go changing the returned statistics.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/net-sysfs.c')
-rw-r--r-- | net/core/net-sysfs.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 146dcfeb060e..afd42d717320 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c | |||
@@ -270,7 +270,6 @@ static ssize_t netstat_show(const struct device *d, | |||
270 | unsigned long offset) | 270 | unsigned long offset) |
271 | { | 271 | { |
272 | struct net_device *dev = to_net_dev(d); | 272 | struct net_device *dev = to_net_dev(d); |
273 | struct net_device_stats *stats; | ||
274 | ssize_t ret = -EINVAL; | 273 | ssize_t ret = -EINVAL; |
275 | 274 | ||
276 | WARN_ON(offset > sizeof(struct net_device_stats) || | 275 | WARN_ON(offset > sizeof(struct net_device_stats) || |
@@ -278,7 +277,7 @@ static ssize_t netstat_show(const struct device *d, | |||
278 | 277 | ||
279 | read_lock(&dev_base_lock); | 278 | read_lock(&dev_base_lock); |
280 | if (dev_isalive(dev)) { | 279 | if (dev_isalive(dev)) { |
281 | stats = dev->get_stats(dev); | 280 | const struct net_device_stats *stats = dev_get_stats(dev); |
282 | ret = sprintf(buf, fmt_ulong, | 281 | ret = sprintf(buf, fmt_ulong, |
283 | *(unsigned long *)(((u8 *) stats) + offset)); | 282 | *(unsigned long *)(((u8 *) stats) + offset)); |
284 | } | 283 | } |