aboutsummaryrefslogtreecommitdiffstats
path: root/net/core/gen_stats.c
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2007-04-19 23:29:13 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2007-04-26 01:26:28 -0400
commit27a884dc3cb63b93c2b3b643f5b31eed5f8a4d26 (patch)
tree5a267e40f9b94014be38dad5de0a52b6628834e0 /net/core/gen_stats.c
parentbe8bd86321fa7f06359d866ef61fb4d2f3e9dce9 (diff)
[SK_BUFF]: Convert skb->tail to sk_buff_data_t
So that it is also an offset from skb->head, reduces its size from 8 to 4 bytes on 64bit architectures, allowing us to combine the 4 bytes hole left by the layer headers conversion, reducing struct sk_buff size to 256 bytes, i.e. 4 64byte cachelines, and since the sk_buff slab cache is SLAB_HWCACHE_ALIGN... :-) Many calculations that previously required that skb->{transport,network, mac}_header be first converted to a pointer now can be done directly, being meaningful as offsets or pointers. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/gen_stats.c')
-rw-r--r--net/core/gen_stats.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c
index 259473d0559d..bcc25591d8ac 100644
--- a/net/core/gen_stats.c
+++ b/net/core/gen_stats.c
@@ -61,7 +61,7 @@ gnet_stats_start_copy_compat(struct sk_buff *skb, int type, int tc_stats_type,
61 spin_lock_bh(lock); 61 spin_lock_bh(lock);
62 d->lock = lock; 62 d->lock = lock;
63 if (type) 63 if (type)
64 d->tail = (struct rtattr *) skb->tail; 64 d->tail = (struct rtattr *)skb_tail_pointer(skb);
65 d->skb = skb; 65 d->skb = skb;
66 d->compat_tc_stats = tc_stats_type; 66 d->compat_tc_stats = tc_stats_type;
67 d->compat_xstats = xstats_type; 67 d->compat_xstats = xstats_type;
@@ -212,7 +212,7 @@ int
212gnet_stats_finish_copy(struct gnet_dump *d) 212gnet_stats_finish_copy(struct gnet_dump *d)
213{ 213{
214 if (d->tail) 214 if (d->tail)
215 d->tail->rta_len = d->skb->tail - (u8 *) d->tail; 215 d->tail->rta_len = skb_tail_pointer(d->skb) - (u8 *)d->tail;
216 216
217 if (d->compat_tc_stats) 217 if (d->compat_tc_stats)
218 if (gnet_stats_copy(d, d->compat_tc_stats, &d->tc_stats, 218 if (gnet_stats_copy(d, d->compat_tc_stats, &d->tc_stats,