diff options
author | Yan, Zheng <zheng.z.yan@intel.com> | 2014-03-22 18:50:39 -0400 |
---|---|---|
committer | Sage Weil <sage@inktank.com> | 2014-04-05 00:07:15 -0400 |
commit | d90deda69cb82411ba7d990e97218e0f8b2d07bb (patch) | |
tree | c99d23f6ec67296c07dd661180c917b8cce2fad6 /net/ceph | |
parent | 5f75ce57818e4a48bdeac0b76daeb434eea26059 (diff) |
libceph: fix oops in ceph_msg_data_{pages,pagelist}_advance()
When there is no more data, ceph_msg_data_{pages,pagelist}_advance()
should not move on to the next page.
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Diffstat (limited to 'net/ceph')
-rw-r--r-- | net/ceph/messenger.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c index 30efc5c18622..4f55f9ce63fa 100644 --- a/net/ceph/messenger.c +++ b/net/ceph/messenger.c | |||
@@ -919,6 +919,9 @@ static bool ceph_msg_data_pages_advance(struct ceph_msg_data_cursor *cursor, | |||
919 | if (!bytes || cursor->page_offset) | 919 | if (!bytes || cursor->page_offset) |
920 | return false; /* more bytes to process in the current page */ | 920 | return false; /* more bytes to process in the current page */ |
921 | 921 | ||
922 | if (!cursor->resid) | ||
923 | return false; /* no more data */ | ||
924 | |||
922 | /* Move on to the next page; offset is already at 0 */ | 925 | /* Move on to the next page; offset is already at 0 */ |
923 | 926 | ||
924 | BUG_ON(cursor->page_index >= cursor->page_count); | 927 | BUG_ON(cursor->page_index >= cursor->page_count); |
@@ -1004,6 +1007,9 @@ static bool ceph_msg_data_pagelist_advance(struct ceph_msg_data_cursor *cursor, | |||
1004 | if (!bytes || cursor->offset & ~PAGE_MASK) | 1007 | if (!bytes || cursor->offset & ~PAGE_MASK) |
1005 | return false; /* more bytes to process in the current page */ | 1008 | return false; /* more bytes to process in the current page */ |
1006 | 1009 | ||
1010 | if (!cursor->resid) | ||
1011 | return false; /* no more data */ | ||
1012 | |||
1007 | /* Move on to the next page */ | 1013 | /* Move on to the next page */ |
1008 | 1014 | ||
1009 | BUG_ON(list_is_last(&cursor->page->lru, &pagelist->head)); | 1015 | BUG_ON(list_is_last(&cursor->page->lru, &pagelist->head)); |