diff options
author | Ang Way Chuang <wcang@sfc.wide.ad.jp> | 2012-12-13 18:08:39 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-12-14 13:14:06 -0500 |
commit | 8fa45a70badf6ce2c57421c17e86e8967ce0d478 (patch) | |
tree | 641681458648b40fef28eddd97c24956ebfea970 /net/bridge | |
parent | 17bc14b767cf0692420c43dbe5310ae98a5a7836 (diff) |
bridge: remove temporary variable for MLDv2 maximum response code computation
As suggested by Stephen Hemminger, this remove the temporary variable
introduced in commit eca2a43bb0d2c6ebd528be6acb30a88435abe307
("bridge: fix icmpv6 endian bug and other sparse warnings")
Signed-off-by: Ang Way Chuang <wcang@sfc.wide.ad.jp>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge')
-rw-r--r-- | net/bridge/br_multicast.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index 1093c89095d8..2561af9d18a2 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c | |||
@@ -1165,7 +1165,6 @@ static int br_ip6_multicast_query(struct net_bridge *br, | |||
1165 | if (max_delay) | 1165 | if (max_delay) |
1166 | group = &mld->mld_mca; | 1166 | group = &mld->mld_mca; |
1167 | } else if (skb->len >= sizeof(*mld2q)) { | 1167 | } else if (skb->len >= sizeof(*mld2q)) { |
1168 | u16 mrc; | ||
1169 | if (!pskb_may_pull(skb, sizeof(*mld2q))) { | 1168 | if (!pskb_may_pull(skb, sizeof(*mld2q))) { |
1170 | err = -EINVAL; | 1169 | err = -EINVAL; |
1171 | goto out; | 1170 | goto out; |
@@ -1173,8 +1172,7 @@ static int br_ip6_multicast_query(struct net_bridge *br, | |||
1173 | mld2q = (struct mld2_query *)icmp6_hdr(skb); | 1172 | mld2q = (struct mld2_query *)icmp6_hdr(skb); |
1174 | if (!mld2q->mld2q_nsrcs) | 1173 | if (!mld2q->mld2q_nsrcs) |
1175 | group = &mld2q->mld2q_mca; | 1174 | group = &mld2q->mld2q_mca; |
1176 | mrc = ntohs(mld2q->mld2q_mrc); | 1175 | max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(ntohs(mld2q->mld2q_mrc)) : 1; |
1177 | max_delay = mrc ? MLDV2_MRC(mrc) : 1; | ||
1178 | } | 1176 | } |
1179 | 1177 | ||
1180 | if (!group) | 1178 | if (!group) |