diff options
author | stephen hemminger <shemminger@vyatta.com> | 2010-05-10 05:31:09 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-05-16 02:10:02 -0400 |
commit | 28a16c97963d3bc36a2c192859f6d8025ef2967a (patch) | |
tree | 01d21938502412959c88757df973cc5a770d1cce /net/bridge/br_stp_if.c | |
parent | cfb478da70f2213520866c84cb0aea0d7c0e1148 (diff) |
bridge: change console message interface
Use one set of macro's for all bridge messages.
Note: can't use netdev_XXX macro's because bridge is purely
virtual and has no device parent.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_stp_if.c')
-rw-r--r-- | net/bridge/br_stp_if.c | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c index d527119e9f54..1d8826914cbf 100644 --- a/net/bridge/br_stp_if.c +++ b/net/bridge/br_stp_if.c | |||
@@ -85,17 +85,16 @@ void br_stp_enable_port(struct net_bridge_port *p) | |||
85 | { | 85 | { |
86 | br_init_port(p); | 86 | br_init_port(p); |
87 | br_port_state_selection(p->br); | 87 | br_port_state_selection(p->br); |
88 | br_log_state(p); | ||
88 | } | 89 | } |
89 | 90 | ||
90 | /* called under bridge lock */ | 91 | /* called under bridge lock */ |
91 | void br_stp_disable_port(struct net_bridge_port *p) | 92 | void br_stp_disable_port(struct net_bridge_port *p) |
92 | { | 93 | { |
93 | struct net_bridge *br; | 94 | struct net_bridge *br = p->br; |
94 | int wasroot; | 95 | int wasroot; |
95 | 96 | ||
96 | br = p->br; | 97 | br_log_state(p); |
97 | printk(KERN_INFO "%s: port %i(%s) entering %s state\n", | ||
98 | br->dev->name, p->port_no, p->dev->name, "disabled"); | ||
99 | 98 | ||
100 | wasroot = br_is_root_bridge(br); | 99 | wasroot = br_is_root_bridge(br); |
101 | br_become_designated_port(p); | 100 | br_become_designated_port(p); |
@@ -127,11 +126,10 @@ static void br_stp_start(struct net_bridge *br) | |||
127 | r = call_usermodehelper(BR_STP_PROG, argv, envp, UMH_WAIT_PROC); | 126 | r = call_usermodehelper(BR_STP_PROG, argv, envp, UMH_WAIT_PROC); |
128 | if (r == 0) { | 127 | if (r == 0) { |
129 | br->stp_enabled = BR_USER_STP; | 128 | br->stp_enabled = BR_USER_STP; |
130 | printk(KERN_INFO "%s: userspace STP started\n", br->dev->name); | 129 | br_debug(br, "userspace STP started\n"); |
131 | } else { | 130 | } else { |
132 | br->stp_enabled = BR_KERNEL_STP; | 131 | br->stp_enabled = BR_KERNEL_STP; |
133 | printk(KERN_INFO "%s: starting userspace STP failed, " | 132 | br_debug(br, "using kernel STP\n"); |
134 | "starting kernel STP\n", br->dev->name); | ||
135 | 133 | ||
136 | /* To start timers on any ports left in blocking */ | 134 | /* To start timers on any ports left in blocking */ |
137 | spin_lock_bh(&br->lock); | 135 | spin_lock_bh(&br->lock); |
@@ -148,9 +146,7 @@ static void br_stp_stop(struct net_bridge *br) | |||
148 | 146 | ||
149 | if (br->stp_enabled == BR_USER_STP) { | 147 | if (br->stp_enabled == BR_USER_STP) { |
150 | r = call_usermodehelper(BR_STP_PROG, argv, envp, 1); | 148 | r = call_usermodehelper(BR_STP_PROG, argv, envp, 1); |
151 | printk(KERN_INFO "%s: userspace STP stopped, return code %d\n", | 149 | br_info(br, "userspace STP stopped, return code %d\n", r); |
152 | br->dev->name, r); | ||
153 | |||
154 | 150 | ||
155 | /* To start timers on any ports left in blocking */ | 151 | /* To start timers on any ports left in blocking */ |
156 | spin_lock_bh(&br->lock); | 152 | spin_lock_bh(&br->lock); |