bluetooth: fix race in bt_procfs_init()

use proc_create_data() rather than set ->data after the file has
been created

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

1 files changed, 1 insertions, 7 deletions

diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c
index 68e6fefb3655..438a8c56938e 100644
--- a/net/bluetooth/af_bluetooth.c
+++ b/net/bluetooth/af_bluetooth.c
@@ -638,16 +638,10 @@ int bt_procfs_init(struct net *net, const char *name,
                    struct bt_sock_list* sk_list,
                    int (* seq_show)(struct seq_file *, void *))
 {
-        struct proc_dir_entry * pde;
-
         sk_list->custom_seq_show = seq_show;
 
-        pde = proc_create(name, 0, net->proc_net, &bt_fops);
-        if (!pde)
+        if (!proc_create_data(name, 0, net->proc_net, &bt_fops, sk_list))
                 return -ENOMEM;
-
-        pde->data = sk_list;
-
         return 0;
 }