aboutsummaryrefslogtreecommitdiffstats
path: root/net/atm/mpc.c
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2012-05-08 14:56:50 -0400
committerDavid S. Miller <davem@davemloft.net>2012-05-09 20:49:17 -0400
commit150238ebb4a1ad2c3d09aea754720ad2e898c59f (patch)
tree9ff803ca540794241bfd07cebde9cc19593a5af6 /net/atm/mpc.c
parent9a7b6ef9b9938a1f5cb91ccc0b713b9443edc79f (diff)
atm: Convert compare_ether_addr to ether_addr_equal
Use the new bool function ether_addr_equal to add some clarity and reduce the likelihood for misuse of compare_ether_addr for sorting. Done via cocci script: $ cat compare_ether_addr.cocci @@ expression a,b; @@ - !compare_ether_addr(a, b) + ether_addr_equal(a, b) @@ expression a,b; @@ - compare_ether_addr(a, b) + !ether_addr_equal(a, b) @@ expression a,b; @@ - !ether_addr_equal(a, b) == 0 + ether_addr_equal(a, b) @@ expression a,b; @@ - !ether_addr_equal(a, b) != 0 + !ether_addr_equal(a, b) @@ expression a,b; @@ - ether_addr_equal(a, b) == 0 + !ether_addr_equal(a, b) @@ expression a,b; @@ - ether_addr_equal(a, b) != 0 + ether_addr_equal(a, b) @@ expression a,b; @@ - !!ether_addr_equal(a, b) + ether_addr_equal(a, b) Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/atm/mpc.c')
-rw-r--r--net/atm/mpc.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/atm/mpc.c b/net/atm/mpc.c
index aa972409f093..d4cc1be5c364 100644
--- a/net/atm/mpc.c
+++ b/net/atm/mpc.c
@@ -592,8 +592,7 @@ static netdev_tx_t mpc_send_packet(struct sk_buff *skb,
592 goto non_ip; 592 goto non_ip;
593 593
594 while (i < mpc->number_of_mps_macs) { 594 while (i < mpc->number_of_mps_macs) {
595 if (!compare_ether_addr(eth->h_dest, 595 if (ether_addr_equal(eth->h_dest, mpc->mps_macs + i * ETH_ALEN))
596 (mpc->mps_macs + i*ETH_ALEN)))
597 if (send_via_shortcut(skb, mpc) == 0) /* try shortcut */ 596 if (send_via_shortcut(skb, mpc) == 0) /* try shortcut */
598 return NETDEV_TX_OK; 597 return NETDEV_TX_OK;
599 i++; 598 i++;