diff options
author | Tejun Heo <tj@kernel.org> | 2012-11-05 12:16:59 -0500 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2012-11-05 12:16:59 -0500 |
commit | bcf6de1b9129531215d26dd9af8331e84973bc52 (patch) | |
tree | 0666760423e4579a50a7752568036a13e0cfa9d5 /mm | |
parent | 9d093cb10eb482adfba6ddc71a0969b78823ee8b (diff) |
cgroup: make ->pre_destroy() return void
All ->pre_destory() implementations return 0 now, which is the only
allowed return value. Make it return void.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Michal Hocko <mhocko@suse.cz>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: Li Zefan <lizefan@huawei.com>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/hugetlb_cgroup.c | 4 | ||||
-rw-r--r-- | mm/memcontrol.c | 3 |
2 files changed, 2 insertions, 5 deletions
diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c index dc595c6b1f55..0d3a1a317731 100644 --- a/mm/hugetlb_cgroup.c +++ b/mm/hugetlb_cgroup.c | |||
@@ -155,7 +155,7 @@ out: | |||
155 | * Force the hugetlb cgroup to empty the hugetlb resources by moving them to | 155 | * Force the hugetlb cgroup to empty the hugetlb resources by moving them to |
156 | * the parent cgroup. | 156 | * the parent cgroup. |
157 | */ | 157 | */ |
158 | static int hugetlb_cgroup_pre_destroy(struct cgroup *cgroup) | 158 | static void hugetlb_cgroup_pre_destroy(struct cgroup *cgroup) |
159 | { | 159 | { |
160 | struct hstate *h; | 160 | struct hstate *h; |
161 | struct page *page; | 161 | struct page *page; |
@@ -172,8 +172,6 @@ static int hugetlb_cgroup_pre_destroy(struct cgroup *cgroup) | |||
172 | } | 172 | } |
173 | cond_resched(); | 173 | cond_resched(); |
174 | } while (hugetlb_cgroup_have_usage(cgroup)); | 174 | } while (hugetlb_cgroup_have_usage(cgroup)); |
175 | |||
176 | return 0; | ||
177 | } | 175 | } |
178 | 176 | ||
179 | int hugetlb_cgroup_charge_cgroup(int idx, unsigned long nr_pages, | 177 | int hugetlb_cgroup_charge_cgroup(int idx, unsigned long nr_pages, |
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 6678f991c6c6..a1811ce60e20 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c | |||
@@ -5002,12 +5002,11 @@ free_out: | |||
5002 | return ERR_PTR(error); | 5002 | return ERR_PTR(error); |
5003 | } | 5003 | } |
5004 | 5004 | ||
5005 | static int mem_cgroup_pre_destroy(struct cgroup *cont) | 5005 | static void mem_cgroup_pre_destroy(struct cgroup *cont) |
5006 | { | 5006 | { |
5007 | struct mem_cgroup *memcg = mem_cgroup_from_cont(cont); | 5007 | struct mem_cgroup *memcg = mem_cgroup_from_cont(cont); |
5008 | 5008 | ||
5009 | mem_cgroup_reparent_charges(memcg); | 5009 | mem_cgroup_reparent_charges(memcg); |
5010 | return 0; | ||
5011 | } | 5010 | } |
5012 | 5011 | ||
5013 | static void mem_cgroup_destroy(struct cgroup *cont) | 5012 | static void mem_cgroup_destroy(struct cgroup *cont) |