diff options
author | Johannes Weiner <hannes@cmpxchg.org> | 2014-08-06 19:05:47 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-08-06 21:01:17 -0400 |
commit | 28c34c291e746aab1c2bfd6d6609b2e47fa0978b (patch) | |
tree | 8c9c3c2264e4a63043c7849c6991d4f7927a6096 /mm | |
parent | 06b078fc065fe1fe7097675c8ee416aa2ef94fb3 (diff) |
mm: memcontrol: reclaim at least once for __GFP_NORETRY
Currently, __GFP_NORETRY tries charging once and gives up before even
trying to reclaim. Bring the behavior on par with the page allocator
and reclaim at least once before giving up.
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Michal Hocko <mhocko@suse.cz>
Cc: Hugh Dickins <hughd@google.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Vladimir Davydov <vdavydov@parallels.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/memcontrol.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index f7b6bec9f538..a73f3947f5d9 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c | |||
@@ -2613,13 +2613,13 @@ retry: | |||
2613 | if (!(gfp_mask & __GFP_WAIT)) | 2613 | if (!(gfp_mask & __GFP_WAIT)) |
2614 | goto nomem; | 2614 | goto nomem; |
2615 | 2615 | ||
2616 | if (gfp_mask & __GFP_NORETRY) | ||
2617 | goto nomem; | ||
2618 | |||
2619 | nr_reclaimed = mem_cgroup_reclaim(mem_over_limit, gfp_mask, flags); | 2616 | nr_reclaimed = mem_cgroup_reclaim(mem_over_limit, gfp_mask, flags); |
2620 | 2617 | ||
2621 | if (mem_cgroup_margin(mem_over_limit) >= batch) | 2618 | if (mem_cgroup_margin(mem_over_limit) >= batch) |
2622 | goto retry; | 2619 | goto retry; |
2620 | |||
2621 | if (gfp_mask & __GFP_NORETRY) | ||
2622 | goto nomem; | ||
2623 | /* | 2623 | /* |
2624 | * Even though the limit is exceeded at this point, reclaim | 2624 | * Even though the limit is exceeded at this point, reclaim |
2625 | * may have been able to free some pages. Retry the charge | 2625 | * may have been able to free some pages. Retry the charge |