diff options
author | Hugh Dickins <hugh@veritas.com> | 2007-10-22 23:45:12 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-23 11:32:06 -0400 |
commit | 1ddd439ef987c9f0209e6ce824b67518f2afe67b (patch) | |
tree | 1f6e0ef40c2b9cf5819d9193d7d06c6a0a33ff6c /mm/mmap.c | |
parent | 4ae3f847e49e3787eca91bced31f8fd328d50496 (diff) |
fix mprotect vma_wants_writenotify prot
Fix mprotect bug in recent commit 3ed75eb8f1cd89565966599c4f77d2edb086d5b0
(setup vma->vm_page_prot by vm_get_page_prot()): the vma_wants_writenotify
case was setting the same prot as when not.
Nothing wrong with the use of protection_map[] in mmap_region(),
but use vm_get_page_prot() there too in the same ~VM_SHARED way.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Cc: Coly Li <coyli@suse.de>
Cc: Tony Luck <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/mmap.c')
-rw-r--r-- | mm/mmap.c | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -1171,8 +1171,7 @@ munmap_back: | |||
1171 | vm_flags = vma->vm_flags; | 1171 | vm_flags = vma->vm_flags; |
1172 | 1172 | ||
1173 | if (vma_wants_writenotify(vma)) | 1173 | if (vma_wants_writenotify(vma)) |
1174 | vma->vm_page_prot = | 1174 | vma->vm_page_prot = vm_get_page_prot(vm_flags & ~VM_SHARED); |
1175 | protection_map[vm_flags & (VM_READ|VM_WRITE|VM_EXEC)]; | ||
1176 | 1175 | ||
1177 | if (!file || !vma_merge(mm, prev, addr, vma->vm_end, | 1176 | if (!file || !vma_merge(mm, prev, addr, vma->vm_end, |
1178 | vma->vm_flags, NULL, file, pgoff, vma_policy(vma))) { | 1177 | vma->vm_flags, NULL, file, pgoff, vma_policy(vma))) { |