aboutsummaryrefslogtreecommitdiffstats
path: root/mm/cma.c
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>2014-10-24 06:18:40 -0400
committerMarek Szyprowski <m.szyprowski@samsung.com>2014-10-27 08:00:54 -0400
commit800a85d3d286604b8c539ca7ee90b992316fd2a7 (patch)
treec284df76d08f4cac4d8e4aa8e746178853efc137 /mm/cma.c
parentf022d8cb7ec70fe8edd56383d876001317ee76b1 (diff)
mm: cma: Always consider a 0 base address reservation as dynamic
The fixed parameter to cma_declare_contiguous() tells the function whether the given base address must be honoured or should be considered as a hint only. The API considers a zero base address as meaning any base address, which must never be considered as a fixed value. Part of the implementation correctly checks both fixed and base != 0, but two locations check the fixed value only. Set fixed to false when base is 0 to fix that and simplify the code. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Acked-by: Michal Nazarewicz <mina86@mina86.com> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Diffstat (limited to 'mm/cma.c')
-rw-r--r--mm/cma.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/mm/cma.c b/mm/cma.c
index 5aa1a6f74dec..62a5dccc3fb8 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -245,6 +245,9 @@ int __init cma_declare_contiguous(phys_addr_t base,
245 size = ALIGN(size, alignment); 245 size = ALIGN(size, alignment);
246 limit &= ~(alignment - 1); 246 limit &= ~(alignment - 1);
247 247
248 if (!base)
249 fixed = false;
250
248 /* size should be aligned with order_per_bit */ 251 /* size should be aligned with order_per_bit */
249 if (!IS_ALIGNED(size >> PAGE_SHIFT, 1 << order_per_bit)) 252 if (!IS_ALIGNED(size >> PAGE_SHIFT, 1 << order_per_bit))
250 return -EINVAL; 253 return -EINVAL;
@@ -268,7 +271,7 @@ int __init cma_declare_contiguous(phys_addr_t base,
268 } 271 }
269 272
270 /* Reserve memory */ 273 /* Reserve memory */
271 if (base && fixed) { 274 if (fixed) {
272 if (memblock_is_region_reserved(base, size) || 275 if (memblock_is_region_reserved(base, size) ||
273 memblock_reserve(base, size) < 0) { 276 memblock_reserve(base, size) < 0) {
274 ret = -EBUSY; 277 ret = -EBUSY;