diff options
author | Tony Lindgren <tony@atomide.com> | 2013-07-31 04:12:49 -0400 |
---|---|---|
committer | Tony Lindgren <tony@atomide.com> | 2013-07-31 04:12:49 -0400 |
commit | dc46c79043a85624c78993919615abf743565ff5 (patch) | |
tree | 085846e275c2d0a069a6a0589307a482351f2829 /lib | |
parent | ad81f0545ef01ea651886dddac4bef6cec930092 (diff) | |
parent | 11dab344053f726fe17ede95aa52c1eea1258a66 (diff) |
Merge tag 'for-v3.11-rc/omap-fixes-a' of git://git.kernel.org/pub/scm/linux/kernel/git/pjw/omap-pending into omap-for-v3.12/cleanup
This series removes the currently-unused PRCM macros from
arch/arm/mach-omap2.
Basic test logs are available at:
http://www.pwsan.com/omap/testlogs/drop_unused_prcm_macros_v3.11-rc/20130721211401/
Once, years ago, we thought that it would be good to document the PRCM
register bits in the Linux codebase. Most folks in the broader
community did not have access to the same documentation, so we thought
that they might be able to use these bits to fix bugs and improve the
code.
We were also able to autogenerate most of these macros, so it was
thought that defining them in advance would reduce the risk of error,
inconsistencies, and merge conflicts caused when patch sets
incrementally defined them by hand.
Well, nice thoughts. But the first rationale was rendered partially
obsolete when TI started to release public TRM documentation PDFs at
some point in the OMAP3 timeframe. (Despite their weaknesses, TI's
public OMAP TRMs remain the most useful public documentation available
for any ARM Linux SoC -- at least to the extent of my knowledge.) And
then the current Linux development tropism towards
development-by-negative-diffstat obliterated the remainder of the
above two philosophies.
So, for the few, the masochistic, out there who wish to continue
developing TI PRCM code, I would ask that you resurrect any
additionally-needed macros from these commits, rather than writing
them manually. Purely for the sake of a pleasant atavism, perhaps; the
way one appreciates a used bookstore, or a video rental store...
And thanks to the upstream maintainers for being patient while we
adjust.
Diffstat (limited to 'lib')
-rw-r--r-- | lib/Kconfig.debug | 2 | ||||
-rw-r--r-- | lib/earlycpio.c | 2 | ||||
-rw-r--r-- | lib/percpu_counter.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 98ac17ed6222..1501aa553221 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug | |||
@@ -238,7 +238,7 @@ config DEBUG_SECTION_MISMATCH | |||
238 | any use of code/data previously in these sections would | 238 | any use of code/data previously in these sections would |
239 | most likely result in an oops. | 239 | most likely result in an oops. |
240 | In the code, functions and variables are annotated with | 240 | In the code, functions and variables are annotated with |
241 | __init, __cpuinit, etc. (see the full list in include/linux/init.h), | 241 | __init,, etc. (see the full list in include/linux/init.h), |
242 | which results in the code/data being placed in specific sections. | 242 | which results in the code/data being placed in specific sections. |
243 | The section mismatch analysis is always performed after a full | 243 | The section mismatch analysis is always performed after a full |
244 | kernel build, and enabling this option causes the following | 244 | kernel build, and enabling this option causes the following |
diff --git a/lib/earlycpio.c b/lib/earlycpio.c index 8078ef49cb79..7aa7ce250c94 100644 --- a/lib/earlycpio.c +++ b/lib/earlycpio.c | |||
@@ -63,7 +63,7 @@ enum cpio_fields { | |||
63 | * the match returned an empty filename string. | 63 | * the match returned an empty filename string. |
64 | */ | 64 | */ |
65 | 65 | ||
66 | struct cpio_data __cpuinit find_cpio_data(const char *path, void *data, | 66 | struct cpio_data find_cpio_data(const char *path, void *data, |
67 | size_t len, long *offset) | 67 | size_t len, long *offset) |
68 | { | 68 | { |
69 | const size_t cpio_header_len = 8*C_NFIELDS - 2; | 69 | const size_t cpio_header_len = 8*C_NFIELDS - 2; |
diff --git a/lib/percpu_counter.c b/lib/percpu_counter.c index 1fc23a3277e1..93c5d5ecff4e 100644 --- a/lib/percpu_counter.c +++ b/lib/percpu_counter.c | |||
@@ -158,7 +158,7 @@ static void compute_batch_value(void) | |||
158 | percpu_counter_batch = max(32, nr*2); | 158 | percpu_counter_batch = max(32, nr*2); |
159 | } | 159 | } |
160 | 160 | ||
161 | static int __cpuinit percpu_counter_hotcpu_callback(struct notifier_block *nb, | 161 | static int percpu_counter_hotcpu_callback(struct notifier_block *nb, |
162 | unsigned long action, void *hcpu) | 162 | unsigned long action, void *hcpu) |
163 | { | 163 | { |
164 | #ifdef CONFIG_HOTPLUG_CPU | 164 | #ifdef CONFIG_HOTPLUG_CPU |