aboutsummaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorHimangi Saraogi <himangi774@gmail.com>2014-08-08 17:22:44 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2014-08-08 18:57:25 -0400
commit89b3ac63013e64621369f619fe732b629879c671 (patch)
tree0f8c23eec330727b2208fe1b0965eb6de9a8cdbb /lib
parent998d6688fb399ab313dcd6f24d1196e3aaa8578c (diff)
kfifo: use BUG_ON
Use BUG_ON(x) rather than if(x) BUG(); The semantic patch that fixes this problem is as follows: // <smpl> @@ identifier x; @@ -if (!x) BUG(); +BUG_ON(!x); // </smpl> Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Cc: Stefani Seibold <stefani@seibold.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib')
-rw-r--r--lib/kfifo.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/kfifo.c b/lib/kfifo.c
index d79b9d222065..90ba1eb1df06 100644
--- a/lib/kfifo.c
+++ b/lib/kfifo.c
@@ -561,8 +561,7 @@ EXPORT_SYMBOL(__kfifo_to_user_r);
561unsigned int __kfifo_dma_in_prepare_r(struct __kfifo *fifo, 561unsigned int __kfifo_dma_in_prepare_r(struct __kfifo *fifo,
562 struct scatterlist *sgl, int nents, unsigned int len, size_t recsize) 562 struct scatterlist *sgl, int nents, unsigned int len, size_t recsize)
563{ 563{
564 if (!nents) 564 BUG_ON(!nents);
565 BUG();
566 565
567 len = __kfifo_max_r(len, recsize); 566 len = __kfifo_max_r(len, recsize);
568 567
@@ -585,8 +584,7 @@ EXPORT_SYMBOL(__kfifo_dma_in_finish_r);
585unsigned int __kfifo_dma_out_prepare_r(struct __kfifo *fifo, 584unsigned int __kfifo_dma_out_prepare_r(struct __kfifo *fifo,
586 struct scatterlist *sgl, int nents, unsigned int len, size_t recsize) 585 struct scatterlist *sgl, int nents, unsigned int len, size_t recsize)
587{ 586{
588 if (!nents) 587 BUG_ON(!nents);
589 BUG();
590 588
591 len = __kfifo_max_r(len, recsize); 589 len = __kfifo_max_r(len, recsize);
592 590