diff options
| author | Andreea-Cristina Bernat <bernat.ada@gmail.com> | 2014-08-22 10:28:22 -0400 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2014-09-10 10:48:47 -0400 |
| commit | fb5a613b4f310d6d520daf295547ab35b0ac58a3 (patch) | |
| tree | fa274f95ec5a819bff04aa1e712d4d5aff54d86a /kernel | |
| parent | 3a630178fd5f30c285fd7016c5340a176b625913 (diff) | |
kernel: trace_syscalls: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
The uses of "rcu_assign_pointer()" are NULLing out the pointers.
According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
Link: http://lkml.kernel.org/p/20140822142822.GA32391@ada
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/trace/trace_syscalls.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c index 759d5e004517..4dc8b79c5f75 100644 --- a/kernel/trace/trace_syscalls.c +++ b/kernel/trace/trace_syscalls.c | |||
| @@ -425,7 +425,7 @@ static void unreg_event_syscall_enter(struct ftrace_event_file *file, | |||
| 425 | return; | 425 | return; |
| 426 | mutex_lock(&syscall_trace_lock); | 426 | mutex_lock(&syscall_trace_lock); |
| 427 | tr->sys_refcount_enter--; | 427 | tr->sys_refcount_enter--; |
| 428 | rcu_assign_pointer(tr->enter_syscall_files[num], NULL); | 428 | RCU_INIT_POINTER(tr->enter_syscall_files[num], NULL); |
| 429 | if (!tr->sys_refcount_enter) | 429 | if (!tr->sys_refcount_enter) |
| 430 | unregister_trace_sys_enter(ftrace_syscall_enter, tr); | 430 | unregister_trace_sys_enter(ftrace_syscall_enter, tr); |
| 431 | mutex_unlock(&syscall_trace_lock); | 431 | mutex_unlock(&syscall_trace_lock); |
| @@ -463,7 +463,7 @@ static void unreg_event_syscall_exit(struct ftrace_event_file *file, | |||
| 463 | return; | 463 | return; |
| 464 | mutex_lock(&syscall_trace_lock); | 464 | mutex_lock(&syscall_trace_lock); |
| 465 | tr->sys_refcount_exit--; | 465 | tr->sys_refcount_exit--; |
| 466 | rcu_assign_pointer(tr->exit_syscall_files[num], NULL); | 466 | RCU_INIT_POINTER(tr->exit_syscall_files[num], NULL); |
| 467 | if (!tr->sys_refcount_exit) | 467 | if (!tr->sys_refcount_exit) |
| 468 | unregister_trace_sys_exit(ftrace_syscall_exit, tr); | 468 | unregister_trace_sys_exit(ftrace_syscall_exit, tr); |
| 469 | mutex_unlock(&syscall_trace_lock); | 469 | mutex_unlock(&syscall_trace_lock); |
