diff options
| author | Nicholas Mc Guire <der.herr@hofr.at> | 2015-01-16 23:05:34 -0500 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2015-02-04 01:57:36 -0500 |
| commit | de30ec47302c101c7badc8fe687641fd75e596e7 (patch) | |
| tree | 15bf011b77ed7850f5b46c85f9940737252ef9fc /kernel | |
| parent | 51587bcf31d070119d37de6103543c807f5ccdb3 (diff) | |
sched/completion: Remove unnecessary ->wait.lock serialization when reading completion state
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1421467534-22834-1-git-send-email-der.herr@hofr.at
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/sched/completion.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/kernel/sched/completion.c b/kernel/sched/completion.c index 607f852b4d04..9d1fe32da232 100644 --- a/kernel/sched/completion.c +++ b/kernel/sched/completion.c | |||
| @@ -288,13 +288,6 @@ EXPORT_SYMBOL(try_wait_for_completion); | |||
| 288 | */ | 288 | */ |
| 289 | bool completion_done(struct completion *x) | 289 | bool completion_done(struct completion *x) |
| 290 | { | 290 | { |
| 291 | unsigned long flags; | 291 | return !!ACCESS_ONCE(x->done); |
| 292 | int ret = 1; | ||
| 293 | |||
| 294 | spin_lock_irqsave(&x->wait.lock, flags); | ||
| 295 | if (!x->done) | ||
| 296 | ret = 0; | ||
| 297 | spin_unlock_irqrestore(&x->wait.lock, flags); | ||
| 298 | return ret; | ||
| 299 | } | 292 | } |
| 300 | EXPORT_SYMBOL(completion_done); | 293 | EXPORT_SYMBOL(completion_done); |
