diff options
author | Zhihui Zhang <zzhsuny@gmail.com> | 2014-08-01 21:18:03 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2014-08-12 06:48:21 -0400 |
commit | aaecac4ad46b35ad308245384d019633fb9bc21b (patch) | |
tree | 2aed8d3c70a31fd90a6cfd781176d802c8ce7c5b /kernel | |
parent | 9a5d9ba6a3631d55c358fe1bdbaa162a97471a05 (diff) |
sched: Rename a misleading variable in build_overlap_sched_groups()
The child variable in build_overlap_sched_groups() actually refers to the
peer or sibling domain of the given CPU. Rename it to sibling to be consistent
with the naming in build_group_mask().
Signed-off-by: Zhihui Zhang <zzhsuny@gmail.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/r/1406942283-18249-1-git-send-email-zzhsuny@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/sched/core.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 1211575a2208..7d1ec6e60535 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c | |||
@@ -5739,7 +5739,7 @@ build_overlap_sched_groups(struct sched_domain *sd, int cpu) | |||
5739 | const struct cpumask *span = sched_domain_span(sd); | 5739 | const struct cpumask *span = sched_domain_span(sd); |
5740 | struct cpumask *covered = sched_domains_tmpmask; | 5740 | struct cpumask *covered = sched_domains_tmpmask; |
5741 | struct sd_data *sdd = sd->private; | 5741 | struct sd_data *sdd = sd->private; |
5742 | struct sched_domain *child; | 5742 | struct sched_domain *sibling; |
5743 | int i; | 5743 | int i; |
5744 | 5744 | ||
5745 | cpumask_clear(covered); | 5745 | cpumask_clear(covered); |
@@ -5750,10 +5750,10 @@ build_overlap_sched_groups(struct sched_domain *sd, int cpu) | |||
5750 | if (cpumask_test_cpu(i, covered)) | 5750 | if (cpumask_test_cpu(i, covered)) |
5751 | continue; | 5751 | continue; |
5752 | 5752 | ||
5753 | child = *per_cpu_ptr(sdd->sd, i); | 5753 | sibling = *per_cpu_ptr(sdd->sd, i); |
5754 | 5754 | ||
5755 | /* See the comment near build_group_mask(). */ | 5755 | /* See the comment near build_group_mask(). */ |
5756 | if (!cpumask_test_cpu(i, sched_domain_span(child))) | 5756 | if (!cpumask_test_cpu(i, sched_domain_span(sibling))) |
5757 | continue; | 5757 | continue; |
5758 | 5758 | ||
5759 | sg = kzalloc_node(sizeof(struct sched_group) + cpumask_size(), | 5759 | sg = kzalloc_node(sizeof(struct sched_group) + cpumask_size(), |
@@ -5763,10 +5763,9 @@ build_overlap_sched_groups(struct sched_domain *sd, int cpu) | |||
5763 | goto fail; | 5763 | goto fail; |
5764 | 5764 | ||
5765 | sg_span = sched_group_cpus(sg); | 5765 | sg_span = sched_group_cpus(sg); |
5766 | if (child->child) { | 5766 | if (sibling->child) |
5767 | child = child->child; | 5767 | cpumask_copy(sg_span, sched_domain_span(sibling->child)); |
5768 | cpumask_copy(sg_span, sched_domain_span(child)); | 5768 | else |
5769 | } else | ||
5770 | cpumask_set_cpu(i, sg_span); | 5769 | cpumask_set_cpu(i, sg_span); |
5771 | 5770 | ||
5772 | cpumask_or(covered, covered, sg_span); | 5771 | cpumask_or(covered, covered, sg_span); |