diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-03-22 19:30:45 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-03-22 20:44:01 -0400 |
| commit | 94dcf29a11b3d20a28790598d701f98484a969da (patch) | |
| tree | 21c65f6634dcde739bb85cbc019ee273f1427f90 /kernel | |
| parent | 207205a2ba2655652fe46a60b49838af6c16a919 (diff) | |
kthread: use kthread_create_on_node()
ksoftirqd, kworker, migration, and pktgend kthreads can be created with
kthread_create_on_node(), to get proper NUMA affinities for their stack and
task_struct.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: David S. Miller <davem@davemloft.net>
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: David Howells <dhowells@redhat.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/softirq.c | 5 | ||||
| -rw-r--r-- | kernel/stop_machine.c | 6 | ||||
| -rw-r--r-- | kernel/workqueue.c | 6 |
3 files changed, 12 insertions, 5 deletions
diff --git a/kernel/softirq.c b/kernel/softirq.c index 56e5dec837f0..735d87095172 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c | |||
| @@ -845,7 +845,10 @@ static int __cpuinit cpu_callback(struct notifier_block *nfb, | |||
| 845 | switch (action) { | 845 | switch (action) { |
| 846 | case CPU_UP_PREPARE: | 846 | case CPU_UP_PREPARE: |
| 847 | case CPU_UP_PREPARE_FROZEN: | 847 | case CPU_UP_PREPARE_FROZEN: |
| 848 | p = kthread_create(run_ksoftirqd, hcpu, "ksoftirqd/%d", hotcpu); | 848 | p = kthread_create_on_node(run_ksoftirqd, |
| 849 | hcpu, | ||
| 850 | cpu_to_node(hotcpu), | ||
| 851 | "ksoftirqd/%d", hotcpu); | ||
| 849 | if (IS_ERR(p)) { | 852 | if (IS_ERR(p)) { |
| 850 | printk("ksoftirqd for %i failed\n", hotcpu); | 853 | printk("ksoftirqd for %i failed\n", hotcpu); |
| 851 | return notifier_from_errno(PTR_ERR(p)); | 854 | return notifier_from_errno(PTR_ERR(p)); |
diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c index 2df820b03beb..e3516b29076c 100644 --- a/kernel/stop_machine.c +++ b/kernel/stop_machine.c | |||
| @@ -301,8 +301,10 @@ static int __cpuinit cpu_stop_cpu_callback(struct notifier_block *nfb, | |||
| 301 | case CPU_UP_PREPARE: | 301 | case CPU_UP_PREPARE: |
| 302 | BUG_ON(stopper->thread || stopper->enabled || | 302 | BUG_ON(stopper->thread || stopper->enabled || |
| 303 | !list_empty(&stopper->works)); | 303 | !list_empty(&stopper->works)); |
| 304 | p = kthread_create(cpu_stopper_thread, stopper, "migration/%d", | 304 | p = kthread_create_on_node(cpu_stopper_thread, |
| 305 | cpu); | 305 | stopper, |
| 306 | cpu_to_node(cpu), | ||
| 307 | "migration/%d", cpu); | ||
| 306 | if (IS_ERR(p)) | 308 | if (IS_ERR(p)) |
| 307 | return notifier_from_errno(PTR_ERR(p)); | 309 | return notifier_from_errno(PTR_ERR(p)); |
| 308 | get_task_struct(p); | 310 | get_task_struct(p); |
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 5ca7ce9ce754..04ef830690ec 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c | |||
| @@ -1366,8 +1366,10 @@ static struct worker *create_worker(struct global_cwq *gcwq, bool bind) | |||
| 1366 | worker->id = id; | 1366 | worker->id = id; |
| 1367 | 1367 | ||
| 1368 | if (!on_unbound_cpu) | 1368 | if (!on_unbound_cpu) |
| 1369 | worker->task = kthread_create(worker_thread, worker, | 1369 | worker->task = kthread_create_on_node(worker_thread, |
| 1370 | "kworker/%u:%d", gcwq->cpu, id); | 1370 | worker, |
| 1371 | cpu_to_node(gcwq->cpu), | ||
| 1372 | "kworker/%u:%d", gcwq->cpu, id); | ||
| 1371 | else | 1373 | else |
| 1372 | worker->task = kthread_create(worker_thread, worker, | 1374 | worker->task = kthread_create(worker_thread, worker, |
| 1373 | "kworker/u:%d", id); | 1375 | "kworker/u:%d", id); |
