diff options
| author | Ken Chen <kenchen@google.com> | 2010-11-11 17:05:16 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-11-12 10:55:31 -0500 |
| commit | 38715258aa2e8cd94bd4aafadc544e5104efd551 (patch) | |
| tree | 1af8d367a68ddcc8868500aa70da21e1eb7ddf5a /kernel | |
| parent | 8d056cb965b8fb7c53c564abf28b1962d1061cd3 (diff) | |
latencytop: fix per task accumulator
Per task latencytop accumulator prematurely terminates due to erroneous
placement of latency_record_count. It should be incremented whenever a
new record is allocated instead of increment on every latencytop event.
Also fix search iterator to only search known record events instead of
blindly searching all pre-allocated space.
Signed-off-by: Ken Chen <kenchen@google.com>
Reviewed-by: Arjan van de Ven <arjan@infradead.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/latencytop.c | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/kernel/latencytop.c b/kernel/latencytop.c index 877fb306d415..17110a4a4fc2 100644 --- a/kernel/latencytop.c +++ b/kernel/latencytop.c | |||
| @@ -194,14 +194,7 @@ __account_scheduler_latency(struct task_struct *tsk, int usecs, int inter) | |||
| 194 | 194 | ||
| 195 | account_global_scheduler_latency(tsk, &lat); | 195 | account_global_scheduler_latency(tsk, &lat); |
| 196 | 196 | ||
| 197 | /* | 197 | for (i = 0; i < tsk->latency_record_count; i++) { |
| 198 | * short term hack; if we're > 32 we stop; future we recycle: | ||
| 199 | */ | ||
| 200 | tsk->latency_record_count++; | ||
| 201 | if (tsk->latency_record_count >= LT_SAVECOUNT) | ||
| 202 | goto out_unlock; | ||
| 203 | |||
| 204 | for (i = 0; i < LT_SAVECOUNT; i++) { | ||
| 205 | struct latency_record *mylat; | 198 | struct latency_record *mylat; |
| 206 | int same = 1; | 199 | int same = 1; |
| 207 | 200 | ||
| @@ -227,8 +220,14 @@ __account_scheduler_latency(struct task_struct *tsk, int usecs, int inter) | |||
| 227 | } | 220 | } |
| 228 | } | 221 | } |
| 229 | 222 | ||
| 223 | /* | ||
| 224 | * short term hack; if we're > 32 we stop; future we recycle: | ||
| 225 | */ | ||
| 226 | if (tsk->latency_record_count >= LT_SAVECOUNT) | ||
| 227 | goto out_unlock; | ||
| 228 | |||
| 230 | /* Allocated a new one: */ | 229 | /* Allocated a new one: */ |
| 231 | i = tsk->latency_record_count; | 230 | i = tsk->latency_record_count++; |
| 232 | memcpy(&tsk->latency_record[i], &lat, sizeof(struct latency_record)); | 231 | memcpy(&tsk->latency_record[i], &lat, sizeof(struct latency_record)); |
| 233 | 232 | ||
| 234 | out_unlock: | 233 | out_unlock: |
