diff options
author | Konstantin Khlebnikov <khlebnikov@openvz.org> | 2012-10-08 19:28:51 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-10-09 03:22:18 -0400 |
commit | 2dd8ad81e31d0d36a5d448329c646ab43eb17788 (patch) | |
tree | cd358be45ed8067673edac7f1db6b6a42a96d9db /kernel | |
parent | 0b173bc4daa8f8ec03a85abf5e47b23502ff80af (diff) |
mm: use mm->exe_file instead of first VM_EXECUTABLE vma->vm_file
Some security modules and oprofile still uses VM_EXECUTABLE for retrieving
a task's executable file. After this patch they will use mm->exe_file
directly. mm->exe_file is protected with mm->mmap_sem, so locking stays
the same.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Acked-by: Chris Metcalf <cmetcalf@tilera.com> [arch/tile]
Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> [tomoyo]
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Carsten Otte <cotte@de.ibm.com>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Eric Paris <eparis@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Acked-by: James Morris <james.l.morris@oracle.com>
Cc: Jason Baron <jbaron@redhat.com>
Cc: Kentaro Takeda <takedakn@nttdata.co.jp>
Cc: Matt Helsley <matthltc@us.ibm.com>
Cc: Nick Piggin <npiggin@kernel.dk>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Venkatesh Pallipadi <venki@google.com>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/auditsc.c | 13 | ||||
-rw-r--r-- | kernel/fork.c | 3 |
2 files changed, 3 insertions, 13 deletions
diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 29e090cc0e46..f4a7756f999c 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c | |||
@@ -1151,7 +1151,6 @@ void audit_log_task_info(struct audit_buffer *ab, struct task_struct *tsk) | |||
1151 | const struct cred *cred; | 1151 | const struct cred *cred; |
1152 | char name[sizeof(tsk->comm)]; | 1152 | char name[sizeof(tsk->comm)]; |
1153 | struct mm_struct *mm = tsk->mm; | 1153 | struct mm_struct *mm = tsk->mm; |
1154 | struct vm_area_struct *vma; | ||
1155 | char *tty; | 1154 | char *tty; |
1156 | 1155 | ||
1157 | if (!ab) | 1156 | if (!ab) |
@@ -1191,16 +1190,8 @@ void audit_log_task_info(struct audit_buffer *ab, struct task_struct *tsk) | |||
1191 | 1190 | ||
1192 | if (mm) { | 1191 | if (mm) { |
1193 | down_read(&mm->mmap_sem); | 1192 | down_read(&mm->mmap_sem); |
1194 | vma = mm->mmap; | 1193 | if (mm->exe_file) |
1195 | while (vma) { | 1194 | audit_log_d_path(ab, " exe=", &mm->exe_file->f_path); |
1196 | if ((vma->vm_flags & VM_EXECUTABLE) && | ||
1197 | vma->vm_file) { | ||
1198 | audit_log_d_path(ab, " exe=", | ||
1199 | &vma->vm_file->f_path); | ||
1200 | break; | ||
1201 | } | ||
1202 | vma = vma->vm_next; | ||
1203 | } | ||
1204 | up_read(&mm->mmap_sem); | 1195 | up_read(&mm->mmap_sem); |
1205 | } | 1196 | } |
1206 | audit_log_task_context(ab); | 1197 | audit_log_task_context(ab); |
diff --git a/kernel/fork.c b/kernel/fork.c index a2b1efc20928..a57a993681ed 100644 --- a/kernel/fork.c +++ b/kernel/fork.c | |||
@@ -656,8 +656,7 @@ struct file *get_mm_exe_file(struct mm_struct *mm) | |||
656 | { | 656 | { |
657 | struct file *exe_file; | 657 | struct file *exe_file; |
658 | 658 | ||
659 | /* We need mmap_sem to protect against races with removal of | 659 | /* We need mmap_sem to protect against races with removal of exe_file */ |
660 | * VM_EXECUTABLE vmas */ | ||
661 | down_read(&mm->mmap_sem); | 660 | down_read(&mm->mmap_sem); |
662 | exe_file = mm->exe_file; | 661 | exe_file = mm->exe_file; |
663 | if (exe_file) | 662 | if (exe_file) |