diff options
| author | Giedrius Rekasius <giedrius.rekasius@gmail.com> | 2014-05-25 10:23:31 -0400 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2014-06-05 05:52:34 -0400 |
| commit | 0b07939cbfdd05bed0c5ec01b8b25493e6ecd34c (patch) | |
| tree | 734d42ef3ee50815f0506fb6fb3baea1f22443c5 /kernel | |
| parent | 5d4dfddd4f02b028d6ddaaa04d75d3b0cad1c9ae (diff) | |
sched: Remove redundant assignment to "rt_rq" in update_curr_rt(...)
Variable "rt_rq" is used only in block "for_each_sched_rt_entity" so the
value assigned to it at the beginning of the update_curr_rt(...) gets
overwritten without ever being read. Remove redundant assignment and
move variable declaration to the block in which it is being used.
Signed-off-by: Giedrius Rekasius <giedrius.rekasius@gmail.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: kernel-janitors@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/r/1401027811-30066-1-git-send-email-giedrius.rekasius@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/sched/rt.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 0ebfd7a29472..43406db306af 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c | |||
| @@ -924,7 +924,6 @@ static void update_curr_rt(struct rq *rq) | |||
| 924 | { | 924 | { |
| 925 | struct task_struct *curr = rq->curr; | 925 | struct task_struct *curr = rq->curr; |
| 926 | struct sched_rt_entity *rt_se = &curr->rt; | 926 | struct sched_rt_entity *rt_se = &curr->rt; |
| 927 | struct rt_rq *rt_rq = rt_rq_of_se(rt_se); | ||
| 928 | u64 delta_exec; | 927 | u64 delta_exec; |
| 929 | 928 | ||
| 930 | if (curr->sched_class != &rt_sched_class) | 929 | if (curr->sched_class != &rt_sched_class) |
| @@ -949,7 +948,7 @@ static void update_curr_rt(struct rq *rq) | |||
| 949 | return; | 948 | return; |
| 950 | 949 | ||
| 951 | for_each_sched_rt_entity(rt_se) { | 950 | for_each_sched_rt_entity(rt_se) { |
| 952 | rt_rq = rt_rq_of_se(rt_se); | 951 | struct rt_rq *rt_rq = rt_rq_of_se(rt_se); |
| 953 | 952 | ||
| 954 | if (sched_rt_runtime(rt_rq) != RUNTIME_INF) { | 953 | if (sched_rt_runtime(rt_rq) != RUNTIME_INF) { |
| 955 | raw_spin_lock(&rt_rq->rt_runtime_lock); | 954 | raw_spin_lock(&rt_rq->rt_runtime_lock); |
