diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-06-15 19:58:10 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-06-15 19:58:10 -0400 |
| commit | ed21a66c1862499bb21c8e48a450e13fb830f46b (patch) | |
| tree | 80bead4a058f2e799884c1220d83c7e1f29b43fb /kernel/watchdog.c | |
| parent | a95f9b6e092ed862278e08266207c7ab231076b4 (diff) | |
| parent | a70270468234749741c5893ae78e5bb524771402 (diff) | |
Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull perf fixes from Ingo Molnar.
* 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
watchdog: Quiet down the boot messages
perf/x86: Fix broken LBR fixup code
tracing: Have tracing_off() actually turn tracing off
Diffstat (limited to 'kernel/watchdog.c')
| -rw-r--r-- | kernel/watchdog.c | 19 |
1 files changed, 18 insertions, 1 deletions
diff --git a/kernel/watchdog.c b/kernel/watchdog.c index e5e1d85b8c7c..4b1dfba70f7c 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c | |||
| @@ -372,6 +372,13 @@ static int watchdog(void *unused) | |||
| 372 | 372 | ||
| 373 | 373 | ||
| 374 | #ifdef CONFIG_HARDLOCKUP_DETECTOR | 374 | #ifdef CONFIG_HARDLOCKUP_DETECTOR |
| 375 | /* | ||
| 376 | * People like the simple clean cpu node info on boot. | ||
| 377 | * Reduce the watchdog noise by only printing messages | ||
| 378 | * that are different from what cpu0 displayed. | ||
| 379 | */ | ||
| 380 | static unsigned long cpu0_err; | ||
| 381 | |||
| 375 | static int watchdog_nmi_enable(int cpu) | 382 | static int watchdog_nmi_enable(int cpu) |
| 376 | { | 383 | { |
| 377 | struct perf_event_attr *wd_attr; | 384 | struct perf_event_attr *wd_attr; |
| @@ -390,11 +397,21 @@ static int watchdog_nmi_enable(int cpu) | |||
| 390 | 397 | ||
| 391 | /* Try to register using hardware perf events */ | 398 | /* Try to register using hardware perf events */ |
| 392 | event = perf_event_create_kernel_counter(wd_attr, cpu, NULL, watchdog_overflow_callback, NULL); | 399 | event = perf_event_create_kernel_counter(wd_attr, cpu, NULL, watchdog_overflow_callback, NULL); |
| 400 | |||
| 401 | /* save cpu0 error for future comparision */ | ||
| 402 | if (cpu == 0 && IS_ERR(event)) | ||
| 403 | cpu0_err = PTR_ERR(event); | ||
| 404 | |||
| 393 | if (!IS_ERR(event)) { | 405 | if (!IS_ERR(event)) { |
| 394 | pr_info("enabled, takes one hw-pmu counter.\n"); | 406 | /* only print for cpu0 or different than cpu0 */ |
| 407 | if (cpu == 0 || cpu0_err) | ||
| 408 | pr_info("enabled on all CPUs, permanently consumes one hw-PMU counter.\n"); | ||
| 395 | goto out_save; | 409 | goto out_save; |
| 396 | } | 410 | } |
| 397 | 411 | ||
| 412 | /* skip displaying the same error again */ | ||
| 413 | if (cpu > 0 && (PTR_ERR(event) == cpu0_err)) | ||
| 414 | return PTR_ERR(event); | ||
| 398 | 415 | ||
| 399 | /* vary the KERN level based on the returned errno */ | 416 | /* vary the KERN level based on the returned errno */ |
| 400 | if (PTR_ERR(event) == -EOPNOTSUPP) | 417 | if (PTR_ERR(event) == -EOPNOTSUPP) |
