diff options
| author | zhangwei(Jovi) <jovi.zhangwei@huawei.com> | 2013-07-18 04:31:05 -0400 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2014-07-15 11:04:40 -0400 |
| commit | 8abfb8727f4a724d31f9ccfd8013fbd16d539445 (patch) | |
| tree | 0076fb34a24b856fcf31f5fa3307e2363a9ea3b3 /kernel/trace | |
| parent | 2448e3493cb3874baa90725c87869455ebf11cd2 (diff) | |
tracing: Add ftrace_trace_stack into __trace_puts/__trace_bputs
Currently trace option stacktrace is not applicable for
trace_printk with constant string argument, the reason is
in __trace_puts/__trace_bputs ftrace_trace_stack is missing.
In contrast, when using trace_printk with non constant string
argument(will call into __trace_printk/__trace_bprintk), then
trace option stacktrace is workable, this inconstant result
will confuses users a lot.
Link: http://lkml.kernel.org/p/51E7A7C9.9040401@huawei.com
Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace')
| -rw-r--r-- | kernel/trace/trace.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index f243444a3772..a6ffc8918dda 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c | |||
| @@ -466,6 +466,9 @@ int __trace_puts(unsigned long ip, const char *str, int size) | |||
| 466 | struct print_entry *entry; | 466 | struct print_entry *entry; |
| 467 | unsigned long irq_flags; | 467 | unsigned long irq_flags; |
| 468 | int alloc; | 468 | int alloc; |
| 469 | int pc; | ||
| 470 | |||
| 471 | pc = preempt_count(); | ||
| 469 | 472 | ||
| 470 | if (unlikely(tracing_selftest_running || tracing_disabled)) | 473 | if (unlikely(tracing_selftest_running || tracing_disabled)) |
| 471 | return 0; | 474 | return 0; |
| @@ -475,7 +478,7 @@ int __trace_puts(unsigned long ip, const char *str, int size) | |||
| 475 | local_save_flags(irq_flags); | 478 | local_save_flags(irq_flags); |
| 476 | buffer = global_trace.trace_buffer.buffer; | 479 | buffer = global_trace.trace_buffer.buffer; |
| 477 | event = trace_buffer_lock_reserve(buffer, TRACE_PRINT, alloc, | 480 | event = trace_buffer_lock_reserve(buffer, TRACE_PRINT, alloc, |
| 478 | irq_flags, preempt_count()); | 481 | irq_flags, pc); |
| 479 | if (!event) | 482 | if (!event) |
| 480 | return 0; | 483 | return 0; |
| 481 | 484 | ||
| @@ -492,6 +495,7 @@ int __trace_puts(unsigned long ip, const char *str, int size) | |||
| 492 | entry->buf[size] = '\0'; | 495 | entry->buf[size] = '\0'; |
| 493 | 496 | ||
| 494 | __buffer_unlock_commit(buffer, event); | 497 | __buffer_unlock_commit(buffer, event); |
| 498 | ftrace_trace_stack(buffer, irq_flags, 4, pc); | ||
| 495 | 499 | ||
| 496 | return size; | 500 | return size; |
| 497 | } | 501 | } |
| @@ -509,6 +513,9 @@ int __trace_bputs(unsigned long ip, const char *str) | |||
| 509 | struct bputs_entry *entry; | 513 | struct bputs_entry *entry; |
| 510 | unsigned long irq_flags; | 514 | unsigned long irq_flags; |
| 511 | int size = sizeof(struct bputs_entry); | 515 | int size = sizeof(struct bputs_entry); |
| 516 | int pc; | ||
| 517 | |||
| 518 | pc = preempt_count(); | ||
| 512 | 519 | ||
| 513 | if (unlikely(tracing_selftest_running || tracing_disabled)) | 520 | if (unlikely(tracing_selftest_running || tracing_disabled)) |
| 514 | return 0; | 521 | return 0; |
| @@ -516,7 +523,7 @@ int __trace_bputs(unsigned long ip, const char *str) | |||
| 516 | local_save_flags(irq_flags); | 523 | local_save_flags(irq_flags); |
| 517 | buffer = global_trace.trace_buffer.buffer; | 524 | buffer = global_trace.trace_buffer.buffer; |
| 518 | event = trace_buffer_lock_reserve(buffer, TRACE_BPUTS, size, | 525 | event = trace_buffer_lock_reserve(buffer, TRACE_BPUTS, size, |
| 519 | irq_flags, preempt_count()); | 526 | irq_flags, pc); |
| 520 | if (!event) | 527 | if (!event) |
| 521 | return 0; | 528 | return 0; |
| 522 | 529 | ||
| @@ -525,6 +532,7 @@ int __trace_bputs(unsigned long ip, const char *str) | |||
| 525 | entry->str = str; | 532 | entry->str = str; |
| 526 | 533 | ||
| 527 | __buffer_unlock_commit(buffer, event); | 534 | __buffer_unlock_commit(buffer, event); |
| 535 | ftrace_trace_stack(buffer, irq_flags, 4, pc); | ||
| 528 | 536 | ||
| 529 | return 1; | 537 | return 1; |
| 530 | } | 538 | } |
