diff options
| author | Steven Rostedt (Red Hat) <rostedt@goodmis.org> | 2015-01-20 11:14:16 -0500 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2015-01-22 11:19:49 -0500 |
| commit | 14a5ae40f0def33a422a45b2ed09198adb7bf11c (patch) | |
| tree | 59fbab59a2c6519b5c95feda7174e58311e3aa2a /kernel/trace | |
| parent | 3efb5f21a36fbddd524cffe36426a84622ce580e (diff) | |
tracing: Use IS_ERR() check for return value of tracing_init_dentry()
tracing_init_dentry() will soon return NULL as a valid pointer for the
top level tracing directroy. NULL can not be used as an error value.
Instead, switch to ERR_PTR() and check the return status with
IS_ERR().
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace')
| -rw-r--r-- | kernel/trace/ftrace.c | 2 | ||||
| -rw-r--r-- | kernel/trace/trace.c | 8 | ||||
| -rw-r--r-- | kernel/trace/trace_events.c | 2 | ||||
| -rw-r--r-- | kernel/trace/trace_functions_graph.c | 2 | ||||
| -rw-r--r-- | kernel/trace/trace_kprobe.c | 2 | ||||
| -rw-r--r-- | kernel/trace/trace_printk.c | 2 | ||||
| -rw-r--r-- | kernel/trace/trace_stack.c | 2 | ||||
| -rw-r--r-- | kernel/trace/trace_stat.c | 2 | ||||
| -rw-r--r-- | kernel/trace/trace_uprobe.c | 2 |
9 files changed, 12 insertions, 12 deletions
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 929a733d302e..80c9d34540dd 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c | |||
| @@ -5419,7 +5419,7 @@ static __init int ftrace_init_debugfs(void) | |||
| 5419 | struct dentry *d_tracer; | 5419 | struct dentry *d_tracer; |
| 5420 | 5420 | ||
| 5421 | d_tracer = tracing_init_dentry(); | 5421 | d_tracer = tracing_init_dentry(); |
| 5422 | if (!d_tracer) | 5422 | if (IS_ERR(d_tracer)) |
| 5423 | return 0; | 5423 | return 0; |
| 5424 | 5424 | ||
| 5425 | ftrace_init_dyn_debugfs(d_tracer); | 5425 | ftrace_init_dyn_debugfs(d_tracer); |
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 7669b1f3234e..acd27555dc5b 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c | |||
| @@ -5820,7 +5820,7 @@ struct dentry *tracing_init_dentry_tr(struct trace_array *tr) | |||
| 5820 | return tr->dir; | 5820 | return tr->dir; |
| 5821 | 5821 | ||
| 5822 | if (!debugfs_initialized()) | 5822 | if (!debugfs_initialized()) |
| 5823 | return NULL; | 5823 | return ERR_PTR(-ENODEV); |
| 5824 | 5824 | ||
| 5825 | if (tr->flags & TRACE_ARRAY_FL_GLOBAL) | 5825 | if (tr->flags & TRACE_ARRAY_FL_GLOBAL) |
| 5826 | tr->dir = debugfs_create_dir("tracing", NULL); | 5826 | tr->dir = debugfs_create_dir("tracing", NULL); |
| @@ -5844,7 +5844,7 @@ static struct dentry *tracing_dentry_percpu(struct trace_array *tr, int cpu) | |||
| 5844 | return tr->percpu_dir; | 5844 | return tr->percpu_dir; |
| 5845 | 5845 | ||
| 5846 | d_tracer = tracing_init_dentry_tr(tr); | 5846 | d_tracer = tracing_init_dentry_tr(tr); |
| 5847 | if (!d_tracer) | 5847 | if (IS_ERR(d_tracer)) |
| 5848 | return NULL; | 5848 | return NULL; |
| 5849 | 5849 | ||
| 5850 | tr->percpu_dir = debugfs_create_dir("per_cpu", d_tracer); | 5850 | tr->percpu_dir = debugfs_create_dir("per_cpu", d_tracer); |
| @@ -6047,7 +6047,7 @@ static struct dentry *trace_options_init_dentry(struct trace_array *tr) | |||
| 6047 | return tr->options; | 6047 | return tr->options; |
| 6048 | 6048 | ||
| 6049 | d_tracer = tracing_init_dentry_tr(tr); | 6049 | d_tracer = tracing_init_dentry_tr(tr); |
| 6050 | if (!d_tracer) | 6050 | if (IS_ERR(d_tracer)) |
| 6051 | return NULL; | 6051 | return NULL; |
| 6052 | 6052 | ||
| 6053 | tr->options = debugfs_create_dir("options", d_tracer); | 6053 | tr->options = debugfs_create_dir("options", d_tracer); |
| @@ -6538,7 +6538,7 @@ static __init int tracer_init_debugfs(void) | |||
| 6538 | trace_access_lock_init(); | 6538 | trace_access_lock_init(); |
| 6539 | 6539 | ||
| 6540 | d_tracer = tracing_init_dentry(); | 6540 | d_tracer = tracing_init_dentry(); |
| 6541 | if (!d_tracer) | 6541 | if (IS_ERR(d_tracer)) |
| 6542 | return 0; | 6542 | return 0; |
| 6543 | 6543 | ||
| 6544 | init_tracer_debugfs(&global_trace, d_tracer); | 6544 | init_tracer_debugfs(&global_trace, d_tracer); |
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 366a78a3e61e..4ff8c1394017 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c | |||
| @@ -2490,7 +2490,7 @@ static __init int event_trace_init(void) | |||
| 2490 | return -ENODEV; | 2490 | return -ENODEV; |
| 2491 | 2491 | ||
| 2492 | d_tracer = tracing_init_dentry(); | 2492 | d_tracer = tracing_init_dentry(); |
| 2493 | if (!d_tracer) | 2493 | if (IS_ERR(d_tracer)) |
| 2494 | return 0; | 2494 | return 0; |
| 2495 | 2495 | ||
| 2496 | entry = debugfs_create_file("available_events", 0444, d_tracer, | 2496 | entry = debugfs_create_file("available_events", 0444, d_tracer, |
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c index ba476009e5de..2d25ad1526bb 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c | |||
| @@ -1437,7 +1437,7 @@ static __init int init_graph_debugfs(void) | |||
| 1437 | struct dentry *d_tracer; | 1437 | struct dentry *d_tracer; |
| 1438 | 1438 | ||
| 1439 | d_tracer = tracing_init_dentry(); | 1439 | d_tracer = tracing_init_dentry(); |
| 1440 | if (!d_tracer) | 1440 | if (IS_ERR(d_tracer)) |
| 1441 | return 0; | 1441 | return 0; |
| 1442 | 1442 | ||
| 1443 | trace_create_file("max_graph_depth", 0644, d_tracer, | 1443 | trace_create_file("max_graph_depth", 0644, d_tracer, |
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 5edb518be345..b4a00def88f5 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c | |||
| @@ -1320,7 +1320,7 @@ static __init int init_kprobe_trace(void) | |||
| 1320 | return -EINVAL; | 1320 | return -EINVAL; |
| 1321 | 1321 | ||
| 1322 | d_tracer = tracing_init_dentry(); | 1322 | d_tracer = tracing_init_dentry(); |
| 1323 | if (!d_tracer) | 1323 | if (IS_ERR(d_tracer)) |
| 1324 | return 0; | 1324 | return 0; |
| 1325 | 1325 | ||
| 1326 | entry = debugfs_create_file("kprobe_events", 0644, d_tracer, | 1326 | entry = debugfs_create_file("kprobe_events", 0644, d_tracer, |
diff --git a/kernel/trace/trace_printk.c b/kernel/trace/trace_printk.c index 7ee4b5cc1ce5..36c1455b7567 100644 --- a/kernel/trace/trace_printk.c +++ b/kernel/trace/trace_printk.c | |||
| @@ -347,7 +347,7 @@ static __init int init_trace_printk_function_export(void) | |||
| 347 | struct dentry *d_tracer; | 347 | struct dentry *d_tracer; |
| 348 | 348 | ||
| 349 | d_tracer = tracing_init_dentry(); | 349 | d_tracer = tracing_init_dentry(); |
| 350 | if (!d_tracer) | 350 | if (IS_ERR(d_tracer)) |
| 351 | return 0; | 351 | return 0; |
| 352 | 352 | ||
| 353 | trace_create_file("printk_formats", 0444, d_tracer, | 353 | trace_create_file("printk_formats", 0444, d_tracer, |
diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c index e80927b88eb0..c3e4fcfddd45 100644 --- a/kernel/trace/trace_stack.c +++ b/kernel/trace/trace_stack.c | |||
| @@ -460,7 +460,7 @@ static __init int stack_trace_init(void) | |||
| 460 | struct dentry *d_tracer; | 460 | struct dentry *d_tracer; |
| 461 | 461 | ||
| 462 | d_tracer = tracing_init_dentry(); | 462 | d_tracer = tracing_init_dentry(); |
| 463 | if (!d_tracer) | 463 | if (IS_ERR(d_tracer)) |
| 464 | return 0; | 464 | return 0; |
| 465 | 465 | ||
| 466 | trace_create_file("stack_max_size", 0644, d_tracer, | 466 | trace_create_file("stack_max_size", 0644, d_tracer, |
diff --git a/kernel/trace/trace_stat.c b/kernel/trace/trace_stat.c index 7af67360b330..75e19e86c954 100644 --- a/kernel/trace/trace_stat.c +++ b/kernel/trace/trace_stat.c | |||
| @@ -276,7 +276,7 @@ static int tracing_stat_init(void) | |||
| 276 | struct dentry *d_tracing; | 276 | struct dentry *d_tracing; |
| 277 | 277 | ||
| 278 | d_tracing = tracing_init_dentry(); | 278 | d_tracing = tracing_init_dentry(); |
| 279 | if (!d_tracing) | 279 | if (IS_ERR(d_tracing)) |
| 280 | return 0; | 280 | return 0; |
| 281 | 281 | ||
| 282 | stat_dir = debugfs_create_dir("trace_stat", d_tracing); | 282 | stat_dir = debugfs_create_dir("trace_stat", d_tracing); |
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index 8520acc34b18..5f0eba9e5e6b 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c | |||
| @@ -1321,7 +1321,7 @@ static __init int init_uprobe_trace(void) | |||
| 1321 | struct dentry *d_tracer; | 1321 | struct dentry *d_tracer; |
| 1322 | 1322 | ||
| 1323 | d_tracer = tracing_init_dentry(); | 1323 | d_tracer = tracing_init_dentry(); |
| 1324 | if (!d_tracer) | 1324 | if (IS_ERR(d_tracer)) |
| 1325 | return 0; | 1325 | return 0; |
| 1326 | 1326 | ||
| 1327 | trace_create_file("uprobe_events", 0644, d_tracer, | 1327 | trace_create_file("uprobe_events", 0644, d_tracer, |
